Giter Club home page Giter Club logo

Comments (3)

matthewgoslett avatar matthewgoslett commented on May 27, 2024 2

Here are references in our laravel4-storage code base.
We allow for both:
getSignedUrl() - returns a temporary signed url to an object
see https://github.com/Superbalist/laravel4-storage/blob/master/src/Filesystem.php#L17

getPublicUrl() - returns a permanent url to a public object
see https://github.com/Superbalist/laravel4-storage/blob/master/src/Filesystem.php#L58

We could easily implement this for public urls.
It gets a little more tricky for signed urls.
We needed to extend the Google_Auth_OAuth2 class to expose the assertion credentials since these are needed in the signing process.
see https://github.com/Superbalist/laravel4-storage/blob/master/src/GoogleAuthOAuth2.php
see https://github.com/Superbalist/laravel4-storage/blob/master/src/StorageAdapterFactory.php#L81

Will implement when we have a moment.

Thanks

from flysystem-google-cloud-storage.

matthewgoslett avatar matthewgoslett commented on May 27, 2024

Yes definitely.
We actually extended Laravel Storage on our side to add hacky support for object urls, so this change will tidy up a lot of the hackery we've had to do on our end.

from flysystem-google-cloud-storage.

matthewgoslett avatar matthewgoslett commented on May 27, 2024

I've added support for getUrl($path) in the latest 3.0.1 release.

from flysystem-google-cloud-storage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.