File stream is dropped on writeStream() about flysystem-google-cloud-storage HOT 5 CLOSED

@violuke You need to check if $someFile is a resource:

if (is_resource($someFile)) {
    fclose($someFile);
}

from flysystem-google-cloud-storage.

Thanks, yes, I know I can check, but I think it's a bug that this adapter works differently to the others?

from flysystem-google-cloud-storage.

@violuke it appears to be normal behavior. According to the official Flysystem documentation:

Some SDK’s close streams after consuming them, therefore, before calling fclose on the resource, check if it’s still valid using is_resource.

https://flysystem.thephpleague.com/v1/docs/usage/filesystem-api/

from flysystem-google-cloud-storage.

You're right, sorry! Thanks for sending that link, that's really helpful. I'll close this as it's not a bug then 👍

from flysystem-google-cloud-storage.

with php 8.x we should not use that anymore, just use

if (!$someFile) { fclose($someFile); }

from flysystem-google-cloud-storage.