Giter Club home page Giter Club logo

Comments (1)

inian avatar inian commented on June 26, 2024

Options

Change getObject to start with /object/auth

  • /object/authenticated/avatars/grumpy.jpg -> getObject -> needs auth header
  • /object/sign/avatars/grumpy.jpg -> getSignedObject -> needs token query param
  • /object/public/avatars/grumpy.jpg -> getPublicObject -> needs bucket to be public

Advantage is that is aligns more closely with /sign and /public in terms of URL structure. Bucket names can be anything.
Problem is everyone will need to upgrade their supabase-js library since this is a breaking change for someone using the getObject API.

Change /object/public/avatars/grumpy.jpg to a new route called /public-object/avatars/grumpy.jpg

Advantage is that there is no breaking change. Bucket can't be named as sign but I guess no one is doing that. Other disadvantage is that API looks messy compared to option 1 but I guess that's fine too.

I think option 2 will be the least messy and during the next breaking change, we move to option 1

from storage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.