Comments (3)
Hi @zhengpd! I didnβt think this would be useful, but I guess why not.
Suggestions:
- Instead of introducing an extra
has_run_args
, perhaps we could use the order in which inputs are added in the first place? (Internally this would be theinputs
method.) - Perhaps we donβt need to raise an error if less args are given, which would allow optional arguments.
- I guess we should also add an extra
run
method with no!
that would callresult
instead ofcall
.
Iβm open for a PR \o/
from actor.
Hi @sunny , after a second thought, I think it's not much value in supporting positional arguments.
Case A: 4 and more inputs
It's not a good idea to define a method with so many positional arguments, so let's ignore this case.
Case B: 2 or 3 inputs
2 or 3 positional arguments seems reasonable. However, the implementation of positional method (eg. run!
) could make the user's project code hard to maintain.
The implementation, going with has_run_args
or relying on internal inputs
order, would mean that developers have to carefully craft the order of defining inputs. If a developer re-sort the inputs in future, it might cause unnoticeable bug when inputs are the same type. For example:
class DivisionActor < Actor
input :y
input :x
def call; y / x; end
end
Positional call is like Actor.run!(4, 2)
. Someday someone might think inputs should be defined in alphabetical ASC order and refactor to
class DivisionActor < Actor
input :x
input :y
def call; y / x; end
end
Now the Actor.run!(4, 2)
succeeds with incorrect result
So, positional arguments like this just adds more complexity to coding
Case C: 1 input
The difference between HiActor.run('Earth')
and HiActor.run(planet: 'Earth')
is pretty small. Not much value in supporting it by adding more complexity into Actor gem, which I prefer to avoid.
Conclusion
It's better to support positional arguments with some other new solution. I'll close this for now.
from actor.
I appreciate the awesome thought process behind this, and happy that you are considering keeping the codebase simple. I agree with your points! Thank you
from actor.
Related Issues (20)
- Raise an error if the :message option is missing on checks HOT 9
- Feature request: use other input values in default HOT 4
- alias_input is documented but unavailable HOT 1
- What about improving the README about testing? HOT 1
- Get "TypeError: exception class/object expected" error when update from 3.1.3 to 3.6 HOT 2
- Question / feature request: hooks around call? HOT 6
- Invoking undefined methods on a result does not raise errors HOT 16
- Ruby 2.3 HOT 3
- Schema explorer HOT 2
- [Feature][Solution included] Allows boolean outputs to have `result.boolean?` accessors instead of `result.boolean` HOT 10
- Evaluate conditions only once HOT 1
- Feature: Promptable HOT 5
- Old bundler & deprecation warnings
- Dependency injection HOT 2
- Play symbols HOT 4
- [This is not an issue per se, rather a question] How to pass in positional arguments, and no keyword arguments? HOT 3
- Problem with `zeitwerk` after update to version 3.4.0 HOT 4
- Validating params or attributes HOT 4
- Problems between checks within the same `input` HOT 8
- warning: method redefined; discarding old orig_name= HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from actor.