Comments (8)
Here we are talking about all the checks, and not just about these two. Those two are just examples. In an amicable way it is necessary to introduce new logic. I'll try to provide a draft as soon as possible.
from actor.
from actor.
Perhaps this is an ordering issue. It looks like it would make sense to always have type
be called before inclusion
.
Would changing the order of the checks solve this for you?
from actor.
In theory, it is correct to take the first check and fall immediately on it. If the first check passes, then take the second and fall on it. And so on until the end.
from actor.
That is, there is not a problem in ordering, but a problem in the positioning of these checks. That is, first need to take the first rule and it doesnβt matter what it is - type or inclusion.
from actor.
In theory need to add all the checks to an array and run them in a loop. But I'm not sure.
from actor.
Oh, I see, you mean that input :currency, type: "String", inclusion: %w[A B]
would act differently to input :currency, inclusion: %w[A B], type: "String"
.
That would make total sense! However it would require rewriting how conditions are applied internally. Iβd be happy to accept a pull-request going in this direction.
Or else, a smaller change that would fix this specific problem here would be to place base.include(ServiceActor::Conditionable)
before TypeCheckable
in lib/service_actor/base.rb
.
from actor.
Released in v3.6.0
from actor.
Related Issues (20)
- Raise an error if the :message option is missing on checks HOT 9
- Feature request: use other input values in default HOT 4
- alias_input is documented but unavailable HOT 1
- What about improving the README about testing? HOT 1
- Get "TypeError: exception class/object expected" error when update from 3.1.3 to 3.6 HOT 2
- Question / feature request: hooks around call? HOT 6
- Invoking undefined methods on a result does not raise errors HOT 16
- Ruby 2.3 HOT 3
- Schema explorer HOT 2
- [Feature][Solution included] Allows boolean outputs to have `result.boolean?` accessors instead of `result.boolean` HOT 10
- Evaluate conditions only once HOT 1
- Feature: Promptable HOT 5
- Old bundler & deprecation warnings
- Dependency injection HOT 2
- Play symbols HOT 4
- [This is not an issue per se, rather a question] How to pass in positional arguments, and no keyword arguments? HOT 3
- Problem with `zeitwerk` after update to version 3.4.0 HOT 4
- Validating params or attributes HOT 4
- warning: method redefined; discarding old orig_name= HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from actor.