Comments (12)
I think this would require drastically changing how this is built, since now an organiser is not really involved in how children share tasks. Also as:
isn’t very explicit in when the value should be changed and how each side is overwritten.
Perhaps there could be some kind of shorthand syntax that would help with this specific case, instead?
For example we could introduce something like:
play CreatePayout,
…
input_rename(owner: :project),
CreateBankAccount,
CreateTransferToBank
from actor.
not bad, but one might find it difficult to understand since we loose the "alias" meaning.
what do you think about alias_input
? (or input_alias
?)
play CreatePayout,
…
alias_input(owner: :project),
CreateBankAccount,
CreateTransferToBank
from actor.
That looks fine to me. Would you care to build a PR for that feature? 🙏🏻
from actor.
Hey ! I made a thing or two regarding this issue. Obvisouly, I missed these last comments
@sunny can I show you what I've done? It's a bit different from what you guys discussed but I'd like to get your opinion. I cannot push any branch on this repo so if you're interested, could you grant me the rights to do so?
from actor.
@AnneSottise I think that you can open a PR from a forked repo
from actor.
Hey @yyamanoi1222, sure, go for it!
from actor.
Do you have an example use-case for that? Could it be solved in plain Ruby by calling alias description aliased_description
?
from actor.
Concrete example!
Nice version:
class PayProject < Actor
input :project, type: Project
play CreatePayout,
...
->(result) { result.owner = result.project },
CreateBankAccount,
CreateTransferToBank
end
Supa dupa nice version
class PayProject < Actor
input :project, type: Project, as: :owner
play CreatePayout,
...
CreateBankAccount,
CreateTransferToBank
end
from actor.
Since the word “rename” implies “changing” the previous, maybe this should be a more generic name tied to the fact that we are copying or aliasing inputs. Perhaps prefixing it by “play” would make sense since it makes it clear we use it in that scenario, e.g.:
play CreatePayout,
…
play_input(owner: :project),
CreateBankAccount,
CreateTransferToBank
from actor.
@williampollet @AnneSottise: would the play_input
syntax work for you, do you think?
from actor.
@AnneSottise Yes you can open a PR directly to the repo from your fork, or you can share a link to a fork 🙏🏻
from actor.
@sunny May I open PR about this issue
from actor.
Related Issues (20)
- Raise an error if the :message option is missing on checks HOT 9
- Feature request: use other input values in default HOT 4
- alias_input is documented but unavailable HOT 1
- What about improving the README about testing? HOT 1
- Get "TypeError: exception class/object expected" error when update from 3.1.3 to 3.6 HOT 2
- Question / feature request: hooks around call? HOT 6
- Invoking undefined methods on a result does not raise errors HOT 16
- Ruby 2.3 HOT 3
- Schema explorer HOT 2
- [Feature][Solution included] Allows boolean outputs to have `result.boolean?` accessors instead of `result.boolean` HOT 10
- Evaluate conditions only once HOT 1
- Feature: Promptable HOT 5
- Old bundler & deprecation warnings
- Dependency injection HOT 2
- Play symbols HOT 4
- [This is not an issue per se, rather a question] How to pass in positional arguments, and no keyword arguments? HOT 3
- Problem with `zeitwerk` after update to version 3.4.0 HOT 4
- Validating params or attributes HOT 4
- Problems between checks within the same `input` HOT 8
- warning: method redefined; discarding old orig_name= HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from actor.