Giter Club home page Giter Club logo

Comments (12)

sunny avatar sunny commented on July 22, 2024 1

I think this would require drastically changing how this is built, since now an organiser is not really involved in how children share tasks. Also as: isn’t very explicit in when the value should be changed and how each side is overwritten.

Perhaps there could be some kind of shorthand syntax that would help with this specific case, instead?

For example we could introduce something like:

play CreatePayout,
     
     input_rename(owner: :project),
     CreateBankAccount,
     CreateTransferToBank

from actor.

williampollet avatar williampollet commented on July 22, 2024 1

not bad, but one might find it difficult to understand since we loose the "alias" meaning.

what do you think about alias_input ? (or input_alias ?)

play CreatePayout,
     
     alias_input(owner: :project),
     CreateBankAccount,
     CreateTransferToBank

from actor.

sunny avatar sunny commented on July 22, 2024 1

That looks fine to me. Would you care to build a PR for that feature? 🙏🏻

from actor.

AnneSottise avatar AnneSottise commented on July 22, 2024 1

Hey ! I made a thing or two regarding this issue. Obvisouly, I missed these last comments 🤡

@sunny can I show you what I've done? It's a bit different from what you guys discussed but I'd like to get your opinion. I cannot push any branch on this repo so if you're interested, could you grant me the rights to do so?

from actor.

williampollet avatar williampollet commented on July 22, 2024 1

@AnneSottise I think that you can open a PR from a forked repo

from actor.

sunny avatar sunny commented on July 22, 2024 1

Hey @yyamanoi1222, sure, go for it!

from actor.

sunny avatar sunny commented on July 22, 2024

Do you have an example use-case for that? Could it be solved in plain Ruby by calling alias description aliased_description?

from actor.

AnneSottise avatar AnneSottise commented on July 22, 2024

Concrete example!

Nice version:

class PayProject < Actor
  input :project, type: Project

  play CreatePayout,
       ...
       ->(result) { result.owner = result.project },
       CreateBankAccount,
       CreateTransferToBank
end

Supa dupa nice version ❤️ :

class PayProject < Actor
  input :project, type: Project, as: :owner

  play CreatePayout,
       ...
       CreateBankAccount,
       CreateTransferToBank
end

from actor.

sunny avatar sunny commented on July 22, 2024

Since the word “rename” implies “changing” the previous, maybe this should be a more generic name tied to the fact that we are copying or aliasing inputs. Perhaps prefixing it by “play” would make sense since it makes it clear we use it in that scenario, e.g.:

play CreatePayout,
     
     play_input(owner: :project),
     CreateBankAccount,
     CreateTransferToBank

from actor.

sunny avatar sunny commented on July 22, 2024

@williampollet @AnneSottise: would the play_input syntax work for you, do you think?

from actor.

sunny avatar sunny commented on July 22, 2024

@AnneSottise Yes you can open a PR directly to the repo from your fork, or you can share a link to a fork 🙏🏻

from actor.

yyamanoi1222 avatar yyamanoi1222 commented on July 22, 2024

@sunny May I open PR about this issue

from actor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.