Comments (3)
Hey @luizfonseca!
Actually the default is applied only if the argument is not given. When given, the default is never applied, even if it's nil
.
The reasoning behind this is to be able to actually pass nil
as a value. This is similar to the way Ruby methods assign defaults. For example:
def my_method(weekdays: [0, 1])
weekdays
end
my_method # => [0, 1]
my_method(weekdays: nil) # => nil
If you want nil
to fallback to the default, you could do something like the following:
class MyInteractor < Actor
input :weekdays,
type: Array,
must: {
be_valid: ->(weekdays) {
weekdays.nil? || weekdays.all?(SomeValidation)
}
},
allow_nil: true
def call
# …
end
def weekdays
super || DEFAULT_WEEKDAYS
end
end
Does that clarify your issue? I'm open to suggestions as to how to make this simpler. Perhaps we could have another option to allow using the given default when the input is nil
? For example, calling it fallback
instead of default
could be an idea.
from actor.
@sunny It does! Thanks for the clarifications!
I am going to close the issue, as my original point has been clarified. Thank you for the great work on the library
from actor.
Luiz, I added a spec with your use-case in a0df1f7. Hopefully this clarifies a bit more the current behavior.
from actor.
Related Issues (20)
- Raise an error if the :message option is missing on checks HOT 9
- Feature request: use other input values in default HOT 4
- alias_input is documented but unavailable HOT 1
- What about improving the README about testing? HOT 1
- Get "TypeError: exception class/object expected" error when update from 3.1.3 to 3.6 HOT 2
- Question / feature request: hooks around call? HOT 6
- Invoking undefined methods on a result does not raise errors HOT 3
- Ruby 2.3 HOT 3
- Schema explorer HOT 2
- [Feature][Solution included] Allows boolean outputs to have `result.boolean?` accessors instead of `result.boolean` HOT 10
- Evaluate conditions only once HOT 1
- Feature: Promptable HOT 5
- Old bundler & deprecation warnings
- Dependency injection HOT 2
- Play symbols HOT 4
- [This is not an issue per se, rather a question] How to pass in positional arguments, and no keyword arguments? HOT 3
- Problem with `zeitwerk` after update to version 3.4.0 HOT 4
- Validating params or attributes HOT 4
- Problems between checks within the same `input` HOT 8
- warning: method redefined; discarding old orig_name= HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from actor.