Giter Club home page Giter Club logo

arclight-demo's People

Contributors

anarchivist avatar camillevilla avatar cbeer avatar cmkpowell avatar corylown avatar dependabot[bot] avatar drhardy avatar eckardm avatar jcoyne avatar jkeck avatar labradford avatar marlo-longley avatar mejackreed avatar mjgiarlo avatar seanaery avatar sul-devops-team avatar taylor-steve avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

arclight-demo's Issues

Ruby dependencies are not updating

On the jenkins server we see.

sul-dlss/arclight-demo
fatal: destination path 'arclight-demo' already exists and is not an empty directory.
From github.com:sul-dlss/arclight-demo
   a02db3f..cd7a05d  master     -> origin/master
Reset branch 'update-dependencies'
HEAD is now at cd7a05d Merge pull request #340 from sul-dlss/update-dependencies
Could not find gem 'arclight' with platforms 'ruby', 'x86_64-linux' in
https://github.com/projectblacklight/arclight.git (at master@cfec8f8).

The source contains the following gems matching 'arclight':
  * arclight-0.5.0
ERROR UPDATING RUBY arclight-demo
Fetching https://github.com/projectblacklight/arclight.git
Fetching https://github.com/projectblacklight/blacklight.git
Fetching gem metadata from https://rubygems.org/...........
On branch update-dependencies
nothing to commit, working tree clean
warning " > [email protected]" has unmet peer dependency "@popperjs/core@^2.11.6".
[update-dependencies 0cad740] Update Yarn dependencies
 1 file changed, 6 insertions(+), 6 deletions(-)
remote: 
remote: Create a pull request for 'update-dependencies' on GitHub by visiting:        
remote:      https://github.com/sul-dlss/arclight-demo/pull/new/update-dependencies        
remote: 
remote: GitHub found 13 vulnerabilities on sul-dlss/arclight-demo's default branch (3 high, 2 moderate, 8 low). To find out more, visit:        
remote:      https://github.com/sul-dlss/arclight-demo/security/dependabot        
remote: 
To github.com:sul-dlss/arclight-demo
 * [new branch]      update-dependencies -> update-dependencies
https://github.com/sul-dlss/arclight-demo/pull/341

The PRs have no ruby updates.

Migrate Universal Analytics (UA) to Google Analytics 4 (GA4)

Universal Analytics (UA) properties will stop collecting data as of July 1, 2023. The data in the existing UA property will remain available for an unspecified period of time. In order to collect data after July 1, 2023 we will need to create a new GA4 property and add the newer gtag.js snippet to the application in order to collect data into the new GA4 property.

Spreadsheet that tracks properties and whether each property is tracking events: https://docs.google.com/spreadsheets/d/1WWt3l-RFqfb_L2j01Y7JBUWJ2OnX0Hi4xLmIW8abNLw/edit?usp=sharing

NOTE: There is currently a setting available that will send events from analytics.js (UA) to GA4 properties. However, Google does not guarantee this will continue to work after July 1, 2023. This is not recommended as a migration path for event tracking.

Component navigation is broken

Clicking +/- to display the child components of a given component is currently broken in the demo. This is happening on collection (top-level) and component pages alike.

Expected behavior: clicking +/- will list only the components that are children of the clicked node.

Current behavior: clicking +/- lists all of the components regardless of the corresponding parent. The parent ID filter (parent_ssi) in the URL hit via AJAX is ignored.

Explanation

This works fine when using Blacklight 7.12.1 but breaks silently in 7.13.0. It appears there was a change then that requires filter parameters to have been configured as facets for the corresponding controller. I.e., this would now be required in catalog_controller.rb:

config.add_facet_field 'parent_ssi', show: false

Screenshots

Screen Shot 2021-08-02 at 9 51 43 AM

ActionView::Template::Error (couldn't find file 'bootstrap/scrollspy' with type 'application/javascript'

Currently on master, spinning up the app leads to the following error:

ActionView::Template::Error (couldn't find file 'bootstrap/scrollspy' with type 'application/javascript'
Checked in these paths:
  /Users/matienzo/Documents/Code/sul-dlss/arclight-demo/app/assets/config
  /Users/matienzo/Documents/Code/sul-dlss/arclight-demo/app/assets/images
  /Users/matienzo/Documents/Code/sul-dlss/arclight-demo/app/assets/javascripts
  /Users/matienzo/Documents/Code/sul-dlss/arclight-demo/app/assets/stylesheets
  /Users/matienzo/Documents/Code/sul-dlss/arclight-demo/vendor/assets/javascripts
  /Users/matienzo/Documents/Code/sul-dlss/arclight-demo/vendor/assets/stylesheets
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/blacklight_range_limit-9b1d1664167f/app/assets/javascripts
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/blacklight_range_limit-9b1d1664167f/app/assets/stylesheets
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/blacklight_range_limit-9b1d1664167f/vendor/assets/javascripts
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/blacklight_range_limit-9b1d1664167f/vendor/assets/stylesheets
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/tether-rails-1.4.0/vendor/assets/javascripts
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/tether-rails-1.4.0/vendor/assets/stylesheets
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/arclight-0.1.3/app/assets/images
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/arclight-0.1.3/app/assets/javascripts
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/arclight-0.1.3/app/assets/stylesheets
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/arclight-0.1.3/vendor/assets/javascripts
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/blacklight-8b9041544553/app/assets/images
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/blacklight-8b9041544553/app/assets/javascripts
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/blacklight-8b9041544553/app/assets/stylesheets
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/jquery-rails-4.3.3/vendor/assets/javascripts
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/coffee-rails-4.2.2/lib/assets/javascripts
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.6/lib/assets/compiled
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actionview-5.1.6/lib/assets/compiled
  /Users/matienzo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/turbolinks-source-5.1.0/lib/assets/javascripts
  /Users/matienzo/Documents/Code/sul-dlss/arclight-demo/node_modules):
    18:
    19:     <title><%= render_page_title %></title>
    20:     <%= opensearch_description_tag application_name, opensearch_catalog_url(format: 'xml') %>
    21:     <%= favicon_link_tag %>
    22:     <%= stylesheet_link_tag "application", media: "all" %>
    23:     <%= javascript_include_tag "application" %>
    24:     <%= csrf_meta_tags %>

Fix arclight-demo deploy

The public ArcLight demo has been down for some time. Given that we've got some upcoming work on ArcLight this fall for Nuremberg, it's important that we have it up and running so @marlo-longley, @ggeisler, and @laurensorensen have a baseline to consult as we do our analysis. Ideally, this should be up and running by the week of LDCY (8/8).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.