sukigu / search-by-image-on-google Goto Github PK

When I try to reverse search images from some sites (like Facebook), I get this error: "The URL doesn't refer to an image or the image is not publicly accessible."

I don't get this error while using these extensions:

• https://github.com/dessant/search-by-image
• https://addons.mozilla.org/en-US/firefox/addon/googlesearch-by-image/

This makes the extension consistent with what Chrome offers and (in my subjective opinion) sounds a little better.

google has changed how it searches images, add:on no longer functional T_T

Due to a recent change in google image search client=firefox-b-d has to be added in the query. Any client name will do, as long as the client parameter has a value, but seems like firefox-b-d is the standard client name for queries originated from Firefox.

If the image you're wanting to search is not publically available without a login, or is from an offline file/page using just the url won't work.
I'm not sure of a solution as there doesn't seem to be a public API for this, so unless the url can just be a base64 data blob there might be a way to look at how the upload image feature works on the actual image search page?

Consider an image with an url like https://example.com/image.jpeg?height=800&width=600. The image search URL requested is going to be https://www.google.com/searchbyimage?image_url=https://example.com/image.jpeg?height=800&width=600 - note that the ? and & are unescaped, so there's no (principled) way for Google to identify the original URL versus what's a genuine parameter being passed for its own receipt. The image URL ought to be explicitly query-encoded before the request URL is constructed.

update with https://www.google.com/searchbyimage?sbisrc=cr_1_5_2&image_url=

At line 20 of background.js, the invocation of browser.tabs.create is explicitly given the index argument. This makes the image search tab open up adjacent to the tab it's invoked from.

However, I have the browser.tabs.insertRelatedAfterCurrent setting set to false, which means that I expect new tabs to be opened at the end; hence, this extension is not behaving in accordance with the rest of Firefox for me.

If this is working as intended, that's fine; I'll go put together the twelve LoC or so to get an extension that works like I'd like it to. However, I suspect that just not specifying index will make the extension do the right thing in all circumstances.