sudsy / node-find-files Goto Github PK

I'm using this library hooked up to a text search field, which calls filereader.startSearch() every time the string changes, so as you type in 'bat', it would start a search for 'b', 'ba', and 'bat'. This results in multiple processes running at once, all but the last of which are out of date, so I was wondering if there's a method to stop any existing searches before starting a new one?

Hi,

I noticed the package is missing the .js file, so I am seeing Cannot find module error.

This is a diff between the packages 0.0.2 and 0.0.3.

In the example, you have a variable named node_find_files .
That is a constructor, by an unspoken convention, all constructors in JS should be Pascal cased. So something like FindFiles would make more sense.

can u please add d.ts file so it can be easily used in typescript project? i tryied to create pull request but code is using non-standard / old style with i cannot compile (u dont even have build script in package.json ...)

If you call finder the following way, you get 'undefined is not a function' errors for every file match, because there is no default filterFunction and the code assumes such function was set in the options.

 var finder = new FindFiles({
        rootFolder: "/home"
 });

If, for example, the filterFunction is set like this, everything works fine:

var finder = new FindFiles({
                rootFolder: "/home",
                filterFunction: function () {
                    return true;
                }
 });

If one of the search criteria is the filename - you can skip the stat function for each file that not equal to the name and speed up the search

I 've experienced performance issues on a server where I used this library over a big directory tree with lots of files.

I 've read your code and saw you are using asyn each.

Maybe adding a config parameter and using eachLimit instead of each so that files would be processed in chunks of parallel tasks, instead of in parallel as a whole.

it may fallback to no limiting if not configured

what do you think?