Giter Club home page Giter Club logo

Comments (4)

espositocode avatar espositocode commented on September 25, 2024

So that is by design, if you look at the official editor themes, ansi blue is rendered as orange. I think this is because Monokai Pro uses a limited color palette that doesn't align perfectly with the ansi variables, so the original designer decided to define them like this.

However, I can try to use the colors appropriately when defining tokens. For example, errors should typically be using red, etc. If you see something that doesn't match up with the official VSCode and Sublime themes, let me know. My primary goal right now is to match up the official themes as closely as I can before I make any additional variations.

from monokai-pro.

TokugawaTakeshi avatar TokugawaTakeshi commented on September 25, 2024

@jontaydev

Thank you for the quick reaction.

I understand you must obey to color guidelines of Monokai theme.
But must we obey to it even if it will confuse the users?
I suppose it will be like replace the yellow and green colors of traffic lights.

Please consider the adding of the harmonious with each Monokai theme blue color for the console as exception.

from monokai-pro.

espositocode avatar espositocode commented on September 25, 2024

There is still more work to be done and I can't start making variations on the official theme right now. Maybe when this theme is more complete I can start looking into template parameters that you can configure at build time.

For now, I think it's pretty easy to modify this specific color in JetBrains. Just select the ansi blue value and choose whatever color you think would be appropriate for that variable (I'm not sure what that would be as there are no "blue" colors in the palette).

I do understand your concern though - it is a bit annoying. Maybe if you contact the original designer he can provide more insight into this decision.

from monokai-pro.

espositocode avatar espositocode commented on September 25, 2024

This guy found a blue color that works nicely: Monokai/monokai-pro-sublime-text#45 (comment)

from monokai-pro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.