Giter Club home page Giter Club logo

Comments (12)

espositocode avatar espositocode commented on June 24, 2024 5

Uploaded 1.2.2 which reverts the default keyword color back to red (which is what Material used). This is technically incorrect, but I will hold off further changes until the converter tool is complete and all languages can be tested more thoroughly in a separate branch.

https://plugins.jetbrains.com/plugin/13643-monokai-pro-theme/versions/stable/118780

from monokai-pro.

espositocode avatar espositocode commented on June 24, 2024 4

Dang, sorry guys. The 1.3.2 patch is available now: https://plugins.jetbrains.com/plugin/13643-monokai-pro-theme/versions/stable/126334

from monokai-pro.

espositocode avatar espositocode commented on June 24, 2024 2

@jlyon87 usually within two days

from monokai-pro.

ekzGuille avatar ekzGuille commented on June 24, 2024 1

@jontaydev I have only seen the light blue keywords what were supposed to be red so far. In my case was the this., return, if, etc. words on Typescript.

image

Left <1.2.1
Right 1.2.1

from monokai-pro.

justin-lyon avatar justin-lyon commented on June 24, 2024 1

Installed 1.2.1 tonight and the issue is particularly jarring in a Java project.

Keywords such as
import, public, private, protected, static, final, primitive types, return (and I'm sure I'm missing a lot more) should be that red/magenta color.

image

from monokai-pro.

3jins avatar 3jins commented on June 24, 2024 1

It seems this issue is reproduced in 1.3.1.
I've rollbacked the plugin to 1.2.2. I'll wait for the fixed version.

from monokai-pro.

ekzGuille avatar ekzGuille commented on June 24, 2024

I've just uploaded to latest version (1.12) and I though the theme was bugged because of some words that were red changed to blue.

from monokai-pro.

espositocode avatar espositocode commented on June 24, 2024

@ekzGuille Did you see an issue introduced in 1.2.1 that needs to be fixed? Or just something unexpected? I'm happy to make minor tweaks for now if needed, until the converter tool is completed.

from monokai-pro.

espositocode avatar espositocode commented on June 24, 2024

I would compare your source with VSCode or Sublime because I think the official default keywords should be blue.

from monokai-pro.

ekzGuille avatar ekzGuille commented on June 24, 2024

image
Same snippet code in Visual Studio Code shows a mixure of both blue and red.

Comparing with VSCode versión I've just noticed Template String (${}) curly braces are different.

Anyway it's a great work!

(It's Filter Machine effect btw)

from monokai-pro.

espositocode avatar espositocode commented on June 24, 2024

I'm gonna hammer away at the converter script a bit more and if it turns out to be too difficult I'll look at some of these differences by hand.

from monokai-pro.

justin-lyon avatar justin-lyon commented on June 24, 2024

Thanks @jontaydev
Can you say when 1.2.2 should arrive in the jetbrains plugin repos?
Nevermind. I just reread your link again. Thank you.

from monokai-pro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.