Diagnostics panel flickers constantly about lsp HOT 12 CLOSED

Each time a new diagnostics response is received, the panel's content is cleared and rebuilt from scratch using "view.insert()" for each message. This causes flickering, if many items are added.

To solve this issue, all responses must be converted to the text content in the background and then be used to replace the whole panal's content with one "view.replace()" call.

EDIT: Maybe the scoll position should even be restored after update rather than scrolling to the bottom.

from lsp.

Debouncing the update would help somewhat here (VS Code seems to use "editor.quickSuggestionsDelay": 10) but I think there's also an issue with the redrawing generally.

from lsp.

This is especially disturbing when the error surpasses a screenful. The whole view starts scrolling a lot

from lsp.

Could you enable log_debug in your settings and share the results of a single keypress? A single diagnostics update should result in 1 update of the panel, but the way we write lines to the panel may not be batched in an efficient manner.

from lsp.

LSP: notify: textDocument/didSave
LSP: notify: textDocument/didSave
LSP: got json:  {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"range":{"end":{"character":10,"line":88},"start":{"character":2,"line":78}},"message":"Warning 34: unused type ac
LSP: got json:  {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"range":{"end":{"character":10,"line":88},"start":{"character":2,"line":78}},"message":"Warning 34: unused type ac

Two here

from lsp.

@deathaxe that sounds like a great fix!
@chenglou Two didSave events! That's not good - are you running some format-on-save logic (eg. another plugin?)?

from lsp.

No format on save

from lsp.

I'm only seeing the one textDocument/didChange event here, but that's still causing the flickering. I'll look at the view.replace() fix and see if that helps.

from lsp.

Merging the PR closed the issue, we can re-open if this hasn't improved.

from lsp.

This is still an issue.

from lsp.

Hi @tsujp, thanks for commenting in the original issue!
Can you share some details (what server are you running, when does it flicker?) A log covering a fresh start to a repro (with the LSP log_debug setting would be much appreciated!

from lsp.

@tomv564 very sorry, I did not have "only_show_lsp_completions": true set which was the cause of the issue, I should've more thoroughly checked the setup. When I removed some things to get the diagnostics I noticed the setting.

So, setting "only_show_lsp_completions": true removed the 'problem' (which was really me hehe).

from lsp.