View closes after canceling Diagnostics Quick Panel about lsp HOT 5 CLOSED

I think this can be closed now?

from lsp.

In DiagnosticInputHandler:

    def cancel(self) -> None:
        if self._preview is not None and self._preview.sheet().is_transient():
            self._preview.close()
        self.window.focus_view(self.view)

The self._preview is the current view. It's supposed to be closed when it's transient but in this case it's not transient so shouldn't close. It's evident that it's not transient by looking at the filename in the tab which is not in cursive.

Even though it's already open, we do call open_location(session, self._get_location(diagnostic), flags=sublime.TRANSIENT) which probably what causes this issue but still the view doesn't look transient so can be argued that it's an ST bug.

from lsp.

I can't reproduce this on latest ST stable build.

What happens if you manually open a file, then run

>>> window.open_file('<put filepath here>', flags=sublime.TRANSIENT)
View(54)
>>> view.sheet().is_transient()
False

in the console, with the filepath of the already opened file?
On my side it just focuses the file (if another tab was active), but the TRANSIENT flag doesn't have any effect on the sheet. Maybe this behavior changed recently in the dev builds?

from lsp.

I've created an ST issue and reproduced that way there: sublimehq/sublime_text#6130

from lsp.

Yep, fixed in ST.

from lsp.