stylishthemes / github-selected-tab-color Goto Github PK

@silverwind see

We dont actually have fs-extra in package.json, should there be or should this be removed?

Yep doesnt work see?

:(

class is .tabs .tab url https://status.github.com/

I can make this work with GitHub Dark Script and untsyled

from

  pagehead-tabs-item.selected, .reponav-item.selected, .btn-link.selected,
  .tabnav-tab.selected {
    border-top-width: 3px !important;
    border-top-color: #5E8ACC !important;
  }

to

  pagehead-tabs-item.selected, .reponav-item.selected, .btn-link.selected,
  .tabnav-tab.selected, .tabs .tab {
    border-top-width: 3px !important;
    border-top-color: #5E8ACC !important;
  }

but not the stylish version, even with a comma between .tabs, .tab hence issue

The issue reported in StylishThemes/GitHub-Dark#895 is happening now when using this style.

Ive removed

@silverwind

Describe the change you'd like

I would prefer either to have a changelog script so we dont have to manually update the changelog or no changelog at all

Additional context

No one actually updates the CHANGELOG.md, before dc7b919 the last update was 6 months ago if we look at CHANGELOG history https://github.com/StylishThemes/GitHub-Selected-Tab-Color/commits/master/CHANGELOG.md it soon becomes apparent its not a file that is in anyones mind.

Ive tried various npm packages to do this job, none comes close to any decent output from our tags or commits. Ive even tried a bash script though it wasnt especially great either.

I vote remove, less hassle.

@Mottie @silverwind @xt0rted

Yep, this is a really odd bug but I confirmed #1 (comment) just now.

1. Disable Github Dark Script if you have it, and use only stylish,
2. In User Styles (Stylish addon) in Firefox edit GitHub Dark
3. Make some changes and save.
4. Notice GitHub-Selected-Tab-Color doesnt work anymore.

Workaround is to edit GitHub-Selected-Tab-Color add/remove a space (to trigger save button active) click save and wall GitHub-Selected-Tab-Color works again.

refreshing/ disabling and re-enabling GitHub-Selected-Tab-Color in stylish has no effect here, as far as I can see.

Unlike GitHub-Dark this style is being applied to github.com so even things like https://styleguide.github.com get it. Should this, and any other GitHub user style, use the same regex that GitHub-Dark is?

^https?://((blog|gist|guides|help|raw|resources|status|developer)\.)?github\.com/((?!generated_pages/preview).)*$

I tried adding it the classes on that seems to be

<button type="button" class="btn-link repo-filter text-small text-muted js-repo-filter-tab filter-selected" data-filter=".public" data-ga-click="Dashboard, click, Repo list filter - context:user filter:public">Public</button>

Obviously needs a masters touch 👍

Doesnt like my moldy cheese Mottie... what will I do now? Cry myself to sleep? </sarcasm>
but none of that worked...

goto https://developer.github.com/v3/ and navigate around top and sidebar.

all pretty much sparse and webhooks section in particular is not part of any style I can tell

Im trying to make sense of what should be added class and bosy wise, so far zippo, nada, not a single turtle, dag or caravan... eh @Mottie 😀

example link StylishThemes/GitHub-Dark#518

<a href="/StylishThemes/GitHub-Dark/pull/518" class="tabnav-tab selected js-pjax-history-navigate">
      <svg aria-hidden="true" class="octicon octicon-comment-discussion" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path fill-rule="evenodd" d="M15 1H6c-.55 0-1 .45-1 1v2H1c-.55 0-1 .45-1 1v6c0 .55.45 1 1 1h1v3l3-3h4c.55 0 1-.45 1-1V9h1l3 3V9h1c.55 0 1-.45 1-1V2c0-.55-.45-1-1-1zM9 11H4.5L3 12.5V11H1V5h4v3c0 .55.45 1 1 1h3v2zm6-3h-2v1.5L11.5 8H6V2h9v6z"></path></svg>
      Conversation

      <span id="conversation_tab_counter" class="Counter">
        6
      </span>
    </a>

As far as I can tell this is part of the css https://github.com/StylishThemes/GitHub-Selected-Tab-Color/blob/master/github-selected-tab-color.css#L11

The other issue is wanted to match my github dark color after installing this into stylus, but I opened the dialog selected my color and userstyles didn't give me a choice to update style.
Solution remove and re-install. Not sure whats going on there.