Giter Club home page Giter Club logo

magresview-2's Introduction

magresview-2

MagresView 2.0 - NMR crystallography visualisation app

Developers

Check out docs/DevArchitecture.md for an explanation of the structure of the software and conventions to adopt.

magresview-2's People

Contributors

stur86 avatar jkshenton avatar

Stargazers

Jonathan Yates avatar Shang Chien avatar

Watchers

 avatar Jonathan Yates avatar  avatar

magresview-2's Issues

Magresview fails to read files containing >100 atoms of a single species

(this is a duplicate of stur86/crystvis-js#26 as I identified this bug in Magresview 2)

When loading a Magres file with >100 atoms sometimes the ^ms lines can end up formatted like

ms H100          2.0431056083497484E+01         -5.5892879764485039E+00          1.2418129913251554E+00         -4.0897852040395684E+00          2.9708843218858465E+01         -3.8875121992744055E+00         -1.1586267278454099E+00          5.0678781904684089E-01          2.4711193494436703E+01

In this case, when crystvis-js reads the ms file it will find only 8 elements, and so throw an error like:

Error parsing file APX_NMR: Input matrix is not symmetric

No atom numbers like Magres 1.6.2

MagresView 1 (generated and?) displayed numbered atom labels even for .magres files that did not contain them.

Best practice seems now include CIF crystallographic labels in the .magres files themselves. But for backwards compatibility, it might be nice to have magresview2 generate crystallographic labels as was done for magresview 1

Expanding on issue raised by @AKM2022

upscaling screenshots

Would it be possible to upscale the screenshot taken? At the moment I think it just captures the canvas view, but it might be nice to be able to use these figures for publication in which case a higher quality figure might be preferable.

Thanks,

Ben

select while in other modes

If you enable ellipsoids for one of the visualisation modes and then return to the select page it's possible to see the ellipsoids for different sites by clicking around. What might be useful is if you could still select atoms while in these other modes as then you could just jump around the structure visualising the ellipsoids in different regions (as it's a bit cumbersome to either show all the ellipsoids or to have to keep switching back and forth).

Thanks,

Ben

Colouring of atoms with Cq

The quadruple coupling is a signed quantity. However, experiments (almost always) measure the magnitude. I'd prefer to colour code based on the magnitude.

At the moment magresview2 can colour code based on Vzz, asymmetry (eta) or Cq. But within the same species (i.e. same nuclear quadrupole moment) Vzz and Cq give the same. I think the old magresView used the modulus of Cq.

Selection box (shift+drag) doesn't add to selection

If I select one atom and then shift-click&drag, the atoms in the box that gets drawn get highlighted correctly, as if selected. However, if I then click 'Display selected', it only displays my initial selection and it ignores (hides) the newly highlighted ones.

The potential bug might actually be in crystvis-js but the issue occurs in this app so I'm adding raising here for now.

Reversing axis doesn't work for spectral plot

In the spectral plot you can’t reverse the axis, for example for the carbon spectrum you will see peaks when you put your x-axis from 0-200 range, and nothing is seen when you put the x-axis range from 200-0 range.

Expanding on issue raised by @AKM2022

ability to remove unit cell

If I am just viewing a single molecule, or a cluster of atoms, can I remove the unit cell.
Related issue - could we then recenter the molecule.

Magresvie 2 issues

Hi,
I have tried Magre 2.0, it would be nice if you could resolve or add the following options to Magresview 2.0.

  1. No option to load as the asymmetric unit
  2. No atom numbers like Magres 1.6.2
  3. Not allowing to select two elements at the same time.
  4. In the Magnetic shielding txt file, the index starts from 0
  5. Would be nice to have a label precision option like Magres 1.6
  6. In the spectral plot you can’t reverse the axis, for example for the carbon spectrum you will see peaks when you put your x-axis from 0-200 range, and nothing is seen when you put the x-axis range from 200-0 range.
  7. No option to download or save the spectral plot.
  8. Would be nice to have an option for Spinsys for SIMPSON.
  9. There is no NMR 2D tool- we use this frequently to compare the experimental 2D spectra to GIPAW calculated one.
  10. On Firefox (and maybe other browsers) selecting an atom that aligns along axes rotates the view.
  11. Dipolar selection operates differently from normal selection in the select and display option. The select and display, dipolar, and calculate Euler angles options are using different selections. Would be nice if all the selection method is the same.
    Thanks

Units for EFG

Currently it is kHz. I think MHz is more useful (with the exception of 2H which has a small Q).

unit cell default centering

When I load a crystal the unit cell is centred on the whole widow width - not the visible width. This would make sense if the side bar could be minimised to reveal the whole width. As it stands the crystal does not always fit in the viewing window (due to this issue).

No option to load as the asymmetric unit

It is very helpful to reduce down (from the full unit cell) to what corresponds to the number of distinct chemical shifts in the solid-state NMR spectrum (i.e., the asymmetric unit).

An alternative could be to have a tool to take in a full unit cell .magres file and output a new .magres file containing just the asymmetric unit cell.

Expanding on issue raised by @AKM2022

molecule detection for 1D chains (polymers)

When selecting a molecule in the attached cif file I don't get the complete molecule. It works for other structures I have tried. I'm not sure what the issue is - but I haven't thought about it too hard (renamed to txt, as GitHub doesn't accept .cif files)
magres_mol_error.txt
.

NMR 2D tool

There is no NMR 2D tool- we use this frequently to compare the experimental 2D spectra to GIPAW calculated one.

Expanding on issue raised by @AKM2022

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.