Giter Club home page Giter Club logo

museumofglitter's People

Contributors

stringtheory avatar

Stargazers

 avatar  avatar

Watchers

 avatar

museumofglitter's Issues

Website is completely illegible when set to Mongolian layouts

I'm not sure what kind of shop you're running over there at the Museum of Glitter, but this:

screenshot_2018-09-13 the museum of glitter

is completely unacceptable to your users in Inner Mongolia!!!

Note the height of this screenshot (which is the minimum height with writing-mode: vertical-lr) is 1631px. Do you honestly expect all of your Inner Mongolian Museum of Glitter patrons to be viewing your site on 4K Ultra HD screens???

By switching to logical properties and values such as min-inline-size instead of width, you would have something much more acceptable, like this:

screenshot_2018-09-13 the museum of glitter 2

Note the much more acceptable minimum height of 606px, completely visible on nearly every screen in Inner Mongolia.

Obviously, the graphics will also need to be adjusted to a more appropriate orientation, but I expect this will be done in the localization process.

Fix immediately or so help me God I will call upon the spirit of Genghis Khan himself to rain down his wrath upon the Museum of Glitter.

[CLOSED] Accessibility: color contrast

The header text may not be accessible enough to individuals browsing your site with vision impairments:

The color combination #ff00ff/#fcecfc has a contrast ratio of 2.77, which is not sufficient. At this size, you will need a ratio of at least 3.

Consider using the following foreground/background combination:
#000000 / #fcecfc, which has a ratio of 18.54.

Otherwise, great work on accessibility! I'm glad this page is still usable for those using a screen reader or other assistive technology.

All imagery without text should be flipped if page declared RTL

Presumably, the disco ball gifs are intended to rotate in a "forward" direction and the unicorn is intended to face in a "backward" direction. If the page is localized to an RTL script like Hebrew, Arabic, Phoenician, or Imperial Aramaic, the disco balls will appear to rotate "backwards" and the unicorn will appear to face "forward":

screenshot from 2018-09-12 19-58-08

This is clearly the unintended behavior.

A possible fix could be to use the :dir() pseudo-class, though it would only work in the latest versions of Firefox.

Please fix immediately.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.