striglia / stockfighter Goto Github PK

The get started docs ought to mention you'll also need to pass in the api_key along with venue and account when initializing.

def place_new_order(self, stock, price, qty, direction, order_type):
"""Place an order for a stock.
https://starfighter.readme.io/docs/place-new-order
"""
url_fragment = 'venues/{venue}/stocks/{stock}/orders'.format(
venue=self.venue,
stock=stock,
)
data = {
"stock": stock,
"venue": self.venue,
"account": self.account,
"qty": qty,
"direction": direction,
"orderType": order_type,
}

hey,

So apparently trying to post something (ie. place_new_order) while using a dated version of requests causes the reponse to return:

TypeError: request() got an unexpected keyword argument 'json'

I believe the default version installed on some machines (mine being ububntu 14.04) is requests 2.2.1 which breaks when

return requests.post(_args, *_kwargs)

is called since this shortcut for the longer post statement is only supported on requests >2.4.2.

In order to avoid users having this issue, we should put in the documentation that users need to be on requests version >2.4.2 (can just be "do this - pip install requests --upgrade or you could add a line in requirements.txt "requests=2.4.2" and have people do "pip install -r requirements.txt" in the getting started section.

Not sure what would be the best way but wanted to report in what I have found.

See https://starfighter.readme.io/docs/quotes-ticker-tape-websocket for details.

People seem to have had luck w/ the ws4py library in python.

Some sharp edges to watch out for:

• https://discuss.starfighters.io/t/websockets-silently-drop-connection-after-5-min-idle/2663
• https://discuss.starfighters.io/t/quotes-going-quiet-after-a-while/2457

I have no idea how to effectively test any of this, since testing API keys aren't yet a real thing.

Right now I need to pull up the source in order to see the API calls. Should be closer to what stockfighter.io provides. If nobody else has claimed it I would be happy to write these, since I'll be using this extensively :)

See PR #14 which did this for the Stockfighter API.

Should clean up some setting of headers and be a negligible performance improvement.

Right now, pip install still delivers a version of the library where terminating instances doesn't work. I know it is additional work, but if you recommend to use pip instead of just checking out the repo PyPI should be up to date.