streetcomplete / streetcomplete Goto Github PK

Reproduce:

1. Open quest to enter opening hours.
2. Add a weekday. Confirm weekday selection.
3. Move app to background. (E.g. switch to home screen.)
4. Receive "has stopped" notification.

Version affected: 0.4 (f-droid.org)

In dense areas, the current zoom settings seem sensible. But in less populated areas, you can have a view with only 1 quest but it doesn't show until you zoom in. So as long as the view would not be cluttered, they should show. Perhaps also some indication of how many (enabled) quests are in the current view.

Consider only to ask for names of highway=residential.
On other streets like highway=unclassified this could lead to bad inputs from unqualified users. "Has no name" may be too often the best answer in this cases.

After completing a quest, I tried to upload it. It sent me to osm OAuth which is fine, but it asked for not only permission to read profile, upload changesets, and change notes, but also to upload traces. StreetComplete's documentation does not talk about recording GPS traces, and certainly it does not talk about uploading them. Permissions should only be requested for things that are reasonably connected with the described functionality.

In addition, if one unchecks "upload GPS traces", the authorization is considered to fail, because not all requested permission were granted. This is really a separate bug - even if there were a documented trace/upload function, it should be possible to do quests without authorizing upload. I am happy to open a separate issue for that, but for now it doesn't seem useful.

when working offline and collecting several answers, they will be uploaded each in single changesets. I would be better to collect them in one single upload changeset.

When inputting my info for registration I couldn't scroll further during the input of the password. Thus I wasn't able to see me typing there (see second image). It still worked though.

May I suggest that language may be changed in settings? In my experience, it is best to have this option activated by users and accessible somewhere.

Clicking Settings and going back to the map view resets the map view to the current location. Would be great to keep the map view pinned while quickly editing settings. Maybe happens with other views, too.

Solid app, keep up the good work 👍

Could a mobility access quest be added? This would be great to add this info on buildings.

I can see all kinds of rendering artefacts with connected ways, which are probably due to issues in the upstream Tangram render. Do you plan on supporting alternative renderers?

Specifically I would love if you could support Mapbox GL as a native renderer (disclaimer: I work for Mapbox but not on the renderer and my involvement with your app is purely private).

https://www.mapbox.com/android-sdk/

What's your take on this?

If this is out of scope feel free to close this issue - no hard feelings ;)

Here are some issues I found after a couple minutes of playing around with the map view

I played around with the beta a little bit and had problems using the app one-handed because zooming seems only be possible using pinch-to-zoom.

Would it be possible to add zoom control buttons (+/-)? Maybe this could be made optional via the settings menu.

First screenshot is taken with the Nexus 4, second one with OnePlus T3. The streetnames didn't render on the Nexus on any zoom level. Maybe related to Nexus 4 screen size?

The app looks promising and it would be great to have it on iOS too.
May not today or in the next months but you could leave the issue open and see how other use responds to it.

I am pretty sure what the app does is ok, but there should be a clear statement of what it does with location data in terms of fetching and uploading data. Presumably other than some kind of data download in the region around the current location and uploading of commits of answered questions, no information would be sent anywhere else. But it would be good to make that claim, if true.

For the 'how many levels does this building have' quest, perhaps the prompts could be changed to:

Total levels (inclusive roof) => Total levels (including the roof)

Of these, levels in the roof* => Of these, how many levels are the roof?

* I am not completely sure what is being asked in the second prompt.

In 9239f1d, a reference to keystore.properties was added, but of course not the file. I get an error building (up-to-date Android Studio). I'm sure I could work around this, but it seems like the sources in github should by default allow building/installing unsigned apks for people to test/debug. If it's easy to make a signed release if keystore.properties is present and just build if not, that would be great.

Sorry for typos and brievety:

On moto g with Android 5: after clicking on an error map pin only the red circle is displayed around position ... But no error description.

But when turning device from portrait mode to landscape mode, error description is then shown!

Anyone can reproduce?

It has been requested by several people to have the option to filter (out) certain quest types.

I would supply this as an option in the settings, listing all quests with a checkmark in front, whether to download and show them or not.

The app should probably filter the number of markers it shows in the map view and prioritize quests for which the added value is high or the frequency in osm is low. Conceptually similar to tf-idf.

To be more specific here: consider the case of ferries. Ferries are tagged route=ferry and a duration tag describes how long the route takes. Without a duration tag you can only guess the duration.

The ferry tag is rare and the duration tags adds high value - a marker for a missing ferry duration tag should probably be prioritized among many opening hour, building level and roof shape markers.

http://wiki.openstreetmap.org/wiki/Tag:route%3Dferry

It would be excellent to have this also on F-Droid, when it is launched. See https://f-droid.org/contribute/ for instructions

Just a note: v0.4 and v0.3 have the same versionCode, which causes some trouble on updates:

package: name='de.westnordost.streetcomplete' versionCode='1' versionName='0.3' platformBuildVersionName=''
package: name='de.westnordost.streetcomplete' versionCode='1' versionName='0.4' platformBuildVersionName=''

Could you please check to increase versionCode with each new release? 😺 Thanks!

I have a couple of smartphones that I only use with WiFi. I opened up streetcomplete with WiFi on downloaded the map and quests. I think I closed streetcomplete turned WiFi off then opened up Streetcomplete again. I could see and complete the quests but since it had WiFi off it couldn't update the OSM database directly.

It gave an error message saying see log.

The edits were held correctly and when WiFi mas enabled a batch was sent up correctly and entered OSM correctly. So it all functioned as it should except the error message when it couldn't send the edits because it was off line.

For a new user this can be confusing.

Have fun John

I see a vast number of opening hours quests. That's fine for many, I suspect, but I'm not that interested in opening hours, and often it's awkward. So I'd like to be able to download and see other types. I suggest a setting with checkboxes for the various kinds of quests.

https://poeditor.com/projects/po_edit?id_language=50&id=97843

Hey,
here's a screen shot of my Android phone with German settings and it doesn't seem to render the "ß". It's supposed to be "Neue Blumenstraße" in Berlin. It shows up correctly in the OSM database (http://www.openstreetmap.org/way/190863137).

I didn't check but maybe there's the same problem for umlauts?

would you like to present the app in osm wiki?

https://wiki.openstreetmap.org/wiki/Android

It would be interesting to be able to point StreetComplete at a maproulette challenge, and have that become a quest. That's probably too hard, but even if there needed to be per-challenge code, being able to hook into the query would be interesting.

For example there is one area where I see no quests at all when zoomed out. But I see quests few streets a little furhter on.
When I zoom in a bit one of the quests appears. Zooming in a bit more and the quest disappears. Zooming in a bit more the previous quest appears again and also a second one.

From my understanding I should see both always in every zoom level.

With this it is very hard to do all the quests in an area because you always miss some of them.

I panned/zoomed to someplace of interest for offline use, and did a manual download. The progress bar finished, but no quests appeared. Panning just the slightest bit made them show up. So there is perhaps a missing call to redraw them after download is complete.

I work on the Open Source Routing Machine and wanted to ask if it's possible to add a quest for routing related tags. We support a variety of tags (see taginfo.json) so I'd like to discuss with you if we could add a routing task and further more which tags make sense to prioritize.

It makes sense to start with high-value tags many routing engines support (for example maxspeed tags) and incrementally add quests for other routing related tags (such as surface, track type and lane tags - and others, see taginfo).

What's your take on this? How can I help?

I'd like the default behavior to be that quests are downloaded only when asked for. I realize others want different behavior, so perhaps on first launch there can be a "Download quests from current location automatically (manual download can always be requested)? Yes/No" to set the preference.

This first screen could also ask the user to authorize OSM. That is often more convenient when installing an app than when trying to use it in the field (not intrinsically, but I often install and try new things in situations where finding my OSM password and typing is easier).

I am very impressed with this app. I have a couple of questions for you.

Is it possible to have a quest for the type of buildings? This is one of the most missing information about buildings. Could a quest be added for mobility access too?

Please add a close dialog if the app is closed.
Otherwise hitting the return button too often closes the app undesired.
Also if there are contributions left they should be commited.

If the app is only put into the background the dialog shouldn't appear.

There are some places that are basically not open, or open by appointment, or 3 times a year they announce they will be open. I don't even know how to represent this in OSM, but it would be good to resolve them by tagging "no regular open hours; usually closed" or something. I suppose this needs a whole new tagging scheme for erratic-almost-never erratic-1h-per-week erratic-frequent. Right now the best I can do is say don't know and hide.

setting an opening hour like 7:30 - 12:30 is tedious because you have to scroll through each of the 30 minutes. Because most of the times should be either *:00 oder *:30 they should be easier to choose. Or is that a operating system component? Because there is a lot of free space on the time choosing page there might be even other possibilities to choose the hours and minutes than the scrolling menu.

Since summer 2016 the google play store has that new beta release feature for apps,

see https://forum.openstreetmap.org/viewtopic.php?id=55203 for some OSM related apps.

Dou you have plans to release a beta apk of osmagent via that way?

Thanks for all your efforts so far.

In some parts of the world the internet doesn't exist. The American red cross have come up with a remote OSM server but it would need the ability to change the pointer in the software to a different server.

This is slow time but I suspect it will be of great interest to the HOT NGOs.

John

sometimes there are objects without a name, like this one:

https://www.openstreetmap.org/node/573381069

Then the app does just ask "What are the opening hours of this object" and you might not know exactly what object is meant (I only guessed it). For this situations it would be better to see something like "what are the opening hours of this object (shop=funeral_directors)"

This is happening all the time, should be simple to reproduce.

A quest for house numbers is much more important from my point of view than the shape of the roof.
In the feature graphic it is already iconed, is there a reason why it is not implemented yet?

For example today I saw that there was nothing while the map showed me a street. Would be nice if I could create a note for myself and/or for osm in such a case.

I would like to download areas and then use the map offline

I just installed StreetComplete through F-Droid and I answered a couple of questions in my area, but I am unable to upload them as when I try to authorize my account I consistently get, "Unable to reach the authorization server" after a timeout of some sort. Searching did not reveal any additional information about this kind of error yet.

I am running Android 7 on an HTC 10 for what it's worth. Not sure what other information might be useful.

Its a Samsung Galaxy S5.

Always reproducible.

Version 0.5

Useful while driving and when the display is off.

Maybe a setting how close one needs to be (100m, 50m, ...).

In JOSM, areas without data are crosshatched. Some visual clue that quests haven't been downloaded within the cache period would be really nice.

PS: the fact that I'm making issues like this is a clue that I have not found anything seriously wrong!