streetcomplete / oneway-data-api Goto Github PK

😄

I deployed it now. However, I have problems when trying to execute the update.php:

The log says

mod_fcgid: read data timeout in 20 seconds
End of script output before headers: update.php

Any ideas?

I do not have access on the webhost to any conf files.

Adding something like

<IfModule mod_fcgid.c>
FcgidIOTimeout 90
</IfModule>

to the .htaccess file does yield in an error, stating [core:alert] .htaccess: FcgidIOTimeout not allowed here. I read that many hosters do not allow changing the setting (this way), so I guess my hoster is the same here.

I created a github organization "StreetComplete". Could we move this repo into the organization?

Seems to be gone now. I contacted @jinalfoflia on OSM slack about it. But maybe she will also read this here.

It came to my mind that it could be useful to include information about the data version in the response. So you and others and quickly see if the served data is up to date without monitoring the log of the cron job. Something like

{
    "dataversion": "20180419",
    "segments": []
}

This also would do that "remember when updated the last time" thing you wished for (though, without the blocking access intention behind it).

@westnordost would you consider this useful? I could implement that.

I've read through the code and noticed a few things. I will just write everything I found in here.

• Relying on fixed column order in CSV (minor): https://github.com/ENT8R/oneway-data-api/blob/master/update.php#L62-L66
• id pkey necessary? (comment): https://github.com/ENT8R/oneway-data-api/blob/master/update.php#L18
• Unnecessary bloat: The whole vendor directory, the autoload stuff and the composer files would be unnecessary if the script would parse the LINESTRING itself into an array (that should be just a few LOC)
• Calling https://ent8r.lima-city.de/oneway-data-api/get.php?bbox=18,-34 yields no error, instead just an empty result
• The result here https://ent8r.lima-city.de/oneway-data-api/get.php?bbox=18,-34,19,-33 encodes the values as strings. (Or would it be better to output the data as CSV anyway?)
• Maybe rename get.php to index.php?