stratus3d / asdf-lua Goto Github PK

Hi,

Tried installing without wget installed, and I got this error:

/Users/lowks/.asdf/plugins/lua/bin/install: line 52: wget: command not found

Those are just bugfix releases of 5.1, did they not build correctly when you tried them?

Lua 5.4.5 and 5.4.6 are available

Hello there! I'm pretty new to this (asdf and its plugins), so bear with me. :)

Is there a way to have asdf install Lua with a Readline-enabled interpreter on Linux? Making it an option, not the default, of course! The make target (and the variable target on bin/install) is linux-readline.

If you can point me in the right direction I can try to implement it and send a PR; for now I'll try to hack my way through this, not knowing better.

EDIT: I wonder if an environment variable is OK, or frowned upon... It would be easy to make something like ASDF_LUA_LINUX_READLINE=1 asdf install lua 5.4.2 work.

I am having this error now. Before it worked very well.

Trying to install LuaJIT causes an error for me.

$ asdf install lua LuaJIT-2.0.5
/Users/kevinsjoberg/.asdf/plugins/lua/bin/../lib/utils.sh: line 38: version_info[2]: unbound variable
/Users/kevinsjoberg/.asdf/plugins/lua/bin/../lib/utils.sh: line 61: pkg_name: unbound variable
/Users/kevinsjoberg/.asdf/plugins/lua/bin/../lib/utils.sh: line 38: version_info[2]: unbound variable
/Users/kevinsjoberg/.asdf/plugins/lua/bin/../lib/utils.sh: line 61: pkg_name: unbound variable

os: macOS 11.2.1
bash: GNU bash, version 5.1.4(1)-release (x86_64-apple-darwin20.2.0)
asdf: v0.8.0-c6145d0

Hello,
Lua 5.4 was released on 29 Jun 2020.

can you add to asdf-lua list?

Thanks!

Thank you for your work. Very handy plugin.

It would be great to add LUA_DIR environment variable during installation (optionally LUA_LIBRARIES and LUA_INCLUDE_DIR but LUA_DIR should be enough) and update them every time during language version switch.

If the number of "jobs" for make is by default set to something greater than 1, the make bootstrap step of installing Luarocks will fail, due to: luarocks/luarocks#1638

Manually setting MAKEFLAGS="--jobs=1 before running make bootstrap works around the issue.

The maintainers of Luarocks seem like they will not fix it in upstream, so maybe it can be added in the install script of this plugin instead?

This affects any system where the default MAKEFLAGS is configured to anything greater than 1, for example systems that do the common thing of setting MAKEFLAGS="--jobs=$(nproc)".

Update: Looks like maybe there will be a fix upstream after all: luarocks/luarocks#1663

If that PR is merged then this issue can be closed.

Something like this should work, if it's not already implemented:

local sort_cmd
if sort --help | grep -q -- '-V'; then
    sort_cmd='sort -r -V'
else
    sort_cmd='sort -r'
fi