Giter Club home page Giter Club logo

stormpath-spring-security's Introduction

The content in this repo has moved

Everything that was here has now been integrated into stormpath-sdk-java since 1.0.RC5

stormpath-spring-security's People

Contributors

brentstormpath avatar dogeared avatar lhazlewood avatar mrioan avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

stormpath-spring-security's Issues

Questions on CustomDataPermissionsEditor constraints

The logic in lookupPermissionStrings appears to indicate that the CustomDataPermissionsEditor expects the CustomData for a user to include a key named fieldName whose value is some Collection<String>, but the verification logic is a bit odd, and it throws an inappropriate exception for the point at which it's validating that assumption.

  • Is that whole method in fact just a wrapper to get such a collection identified by the fieldName key?
  • If the Collection contents of the key have a different contained type, is it better to throw an exception or coerce them all through toString?
  • If throwing an exception is the appropriate action there, is there a strong reason not to run through these checks eagerly when creating the editor object?

Formatting question

I note that your code tends to be space-formatted instead of tab-formatted (Eclipse defaults to 4-space tabs inline). Is this a particular formatting choice for your project that submissions need to match?

SpringSecurityResolvedAccountFilter produces a new Authentication on every request

While the purpose of SpringSecurityResolvedAccountFilter is clear to me, I have a feeling it should not produce a new Authentication every time it runs. Each authentication means reading the Groups the user is member of, and this is very costly as collections are not (yet) cached.

I think the SpringSecurityResolvedAccountFilter should check if the current Authentication (the user href inside the UserDetails) matches the account resolved from request (probably from cookie param). Only if the authentication in the context does not match, or does not exist, a new authentication should be performed.

I've modified the filter to meet those needs and it works quite good, eliminating the communication to Stormpath on every possible request. The performance gains are very noticable, esp. where there are a lot of resources to load (css, js, images)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.