Giter Club home page Giter Club logo

gildedrosekata's Introduction

GildedRoseKata

Kata for GildedRose

This is my attempt at the Gilded Rose Kata. I began by creating the first 10 tests that you see to ensure base functions worked. I needed to make Items public so I would be able to assert its values from the Test project.

After I felt comfortable with the solution, I started with my refactoring. In the beginning, I was pulling out the increasing and decreasing of the quality to a separate function to make it easier to read, and see how often this was done. After I had done that, I looked at what changes between the items:

  • Behavior when updating the quality -- Default behavior was to degrade by 1; however, the Aged Brie and Backstage Passes increased in quality
  • The SellIn date, but Sulfuras' never needed to change.
  • The Quality changed when past the Sell In date. For most items, it reduced by 1 until it hit 0. However, Backstage pass decreased at a different rate.

Due to this, I wanted to try my attempt at the strategy pattern, using a factory to build the Products that wrapped Item with a behavior, and a couple null object pattern when the behavior was to do nothing.

Things I'd Like to Do:

  • There are common checks - Quality cannot be less than 0 nor greater than 50, and the PostSellIn only kicked in when past Sell Date, so I would like to build that into base functionality of that behavior

gildedrosekata's People

Contributors

steventmayer avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.