Comments (8)
Hi, the solution is, as Steven already said, in the binning of the folded lightcurve. But 250 seems to be too much.
After also struggling with NaN values, since I use bins=100, no more problems. And I use Triceratops a lot...
I'm afraid I can't explain why this works, but it does...
I tried your file with bins = 100 and got:
from triceratops.
Interesting. Thanks for your answer. The only thing that concerns me is the fact that using only 100 points to represent the transit with some baseline could be not enough to properly compare it to any given model. What do you think?
from triceratops.
I'm not an expert, but quoting Steven in example.ipynb of this repository:
"If you have a lot of data points, I recommend binning your light curve down to ~100 to save time. Binning your data is poor practice when fitting light curves for a planet's parameters, but it doesn't yield significantly different results for our purposes"
from triceratops.
Don't know why I read 1000 instead of 100. Thanks for pointing it out.
from triceratops.
That still doesn't explain why we can't use more points, but I'll stick to that number of bins given it makes the algorithm work properly most of the times.
from triceratops.
I have been having similar problems, though it might not be related. In my case, the code only sometimes returns NaNs (I assume because whatever is producing NaN is part of the random draw process). Some combinations of lightcurves and contrast curves seem more likely to produce NaNs. In particular, I seem to be getting the most NaNs when I use the more constraining contrast curve; 8 of the FPPs out of the loop of 20 I just ran are NaN.
from triceratops.
I've run into that issue with contrast curves too and have come up with a solution, but I haven't pushed it to the repo yet. I'm hoping to update the code with a fix for both of these within the next ~2 weeks.
from triceratops.
Okay, these issues should be resolved with the latest update (1.0.9), which I just pushed. You should now be able to run the code with all of your data points (I'm sure there is an upper limit, but I have't encountered it) and any contrast curve. I'm going to close this thread, but definitely open it again if you continue to run into these issues.
from triceratops.
Related Issues (20)
- v1.0.8 returns empty probs when Ms < 0.1 HOT 8
- [Question] Support for Kepler data HOT 11
- celerite not specified as a requirement HOT 1
- NaN FPP for Kepler target HOT 4
- progress bar? HOT 1
- More contrast curves HOT 1
- Allow using different download_dir for lightkurve HOT 1
- TypingError in triceratops.target.calc_probs HOT 7
- Huge variations in FPP HOT 4
- HTTP connection issue HOT 1
- The current version (2022-12-02) does not work with numpy>=1.23 HOT 2
- calc_probs() raissed HTTP 400 Error from trilegal if the target instance is used for a long time
- Clarify on the nearby stars included in analysis HOT 2
- [Question] Use triceratops probabilities as priors HOT 3
- [Bug] Error when kepler target not in catalog HOT 2
- [Bug] Triceratops times out HOT 4
- [Bug] HTTP Error 404: Not Found HOT 1
- Pytransit issues HOT 6
- issue with the plot of the different scenarios
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from triceratops.