stephenyeargin / hubot-untappd-friends Goto Github PK

Hi,

Slack has some really nice options for displaying neatly formatted messages, including inline images. This would be a perfect fit for untappd, as we could then show the users avatar, pictures of the beer, or the badge they've earned. I'm sure other platforms like Hipchat, etc have their own method of doing the same.

Does anyone have any advice on how we could best format messages based on the adapter in use? I wouldn't want to break compatibility with anything. This sort of pluggable message format would seem like something that's a solved problem, but I've not found anything online yet.

I've heard that "running the board" is some great feat, and yet when I've achieved this prestigious state of drunkenness, nothing happens.

I propose that if the last ten contiguous checkins are in the same location, the bot should applaude/salute/give $100 to all of the talented drinkers who sacrificed their livers for this achievement.

It would be nice to be able to remove a friend, particularly if they've left the organization.

The following checklist is for all of the Hubot packages I maintain.

README.md

• Badges (underneath title)

[![npm version](https://badge.fury.io/js/hubot-PACKAGE_NAME.svg)](http://badge.fury.io/js/hubot-PACKAGE_NAME) [![Build Status](https://travis-ci.org/stephenyeargin/hubot-PACKAGE_NAME.png)](https://travis-ci.org/stephenyeargin/hubot-PACKAGE_NAME)

• Configuration options

package.json

• author

  "author": "Stephen Yeargin <[email protected]>",

• repository

  "repository": {
    "type": "git",
    "url": "git://github.com/stephenyeargin/hubot-PACKAGE_NAME.git"
  },

• bugs

  "bugs": {
    "url": "https://github.com/stephenyeargin/hubot-PACKAGE_NAME/issues"
  },

• peerDependencies

  "peerDependencies": {
    "hubot": ">=2 <10 || 0.0.0-development"
  },

Gruntfile.js

• additionalFiles

        additionalFiles: ['package-lock.json']

.travis.yml

• TravisCI configuration

language: node_js
sudo: false
notifications:
  email: false
node_js:
  - "8" # stable
  - "6" # LTS
  - "4" # maintenance
cache:
  directories:
- node_modules

Our version of node-untappd is out of date. There are some breaking changes to work through.

When drinking a beer that starts with a vowel, the response still uses a vs an. While cosmetic, it bothers me. :)

Some changes came through with #10 that altered the expected behavior for this package. If the bot knows many users named Chris, for example, it won't be clear which user had the beer.

[22:13:02] @crunchy:	Chris was drinking a Ron Mexico (IPA - American - 4.5%) by Russian River Brewing Company at Russian River Brewing Company - 7 minutes ago
[22:13:03] @crunchy:	Chris was drinking a 22nd Anniversary NE IPA (IPA - New England - 6.1%) by Third Street Aleworks (California) at Local Barrel - 37 minutes ago
[22:13:03] @crunchy:	Brandon was drinking a Figuers of Light (Pale Ale - American - 5.9%) by Riff Raff Brewing Co. at Riff Raff Brewing Co. - 2 hours ago
[22:13:03] @crunchy:	Brandon was drinking a Hopgoblin American IPA (IPA - American - 6.5%) by Riff Raff Brewing Co. at Riff Raff Brewing Co. - 2 hours ago

/cc @stahnma

Hi @stephenyeargin - sorry, the latest version 1.0.7 doesn't seem to work. Firstly, I'm fairly new to npm, so please excuse my ignorance.

I couldn't believe it was the change the environment variable name, so I had a look at the results of install 1.0.6 and 1.0.7 via npm to see if there was perhaps something that changed in the packaging.

The ./node_modules/hubot-untappd-friends/package.json seems to differ between 1.0.6 and 1.0.7 in a few ways:

• _npmVersion changes from 1.4.23 to 3.10.9
• The dependency of moment has moved from ~2.5.0 to ^2.18.1
• The dependency of node-untappd has moved from ~0.3.1 to ~0.4.1

I'm going to guess that there's something in the new version of node-untappd that's not compatible with hubot-untappd-friends ?

Package poitnts to "node-untappd": "stephenyeargin/node-untappd#fix-for-pending-friends"
which doesn't appear to be resolvable from yarn or npm.

Figure out what's broken.