Giter Club home page Giter Club logo

Comments (3)

stephenberry avatar stephenberry commented on May 27, 2024

Thanks for reporting this. I don't currently have a good way of testing clang on windows. I have a few questions:

Notice the #if defined(_MSC_VER), should this be defined for clang?

What versions of clang for windows are you using?

from glaze.

Wolfleader101 avatar Wolfleader101 commented on May 27, 2024

Thanks for reporting this. I don't currently have a good way of testing clang on windows. I have a few questions:

Notice the #if defined(_MSC_VER), should this be defined for clang?

What versions of clang for windows are you using?

Hey,

I tried playing around with it yesterday, and I think I found the problem.
I thought at first maybe my clang install was busted as _MSC_VER was being defined, but __clang__ is also defined, and after some googling I found that its due to clang trying to stay compatible with MSVC compiled code.

My Clang Version for reference.

image

I believe the appropriate fix is to have:
#if defined(_MSC_VER) && !defined(__clang__)

This is linked to PR #701

from glaze.

stephenberry avatar stephenberry commented on May 27, 2024

Thanks for solving this. I merged your pull request.

from glaze.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.