Comments (5)
I see. In my case I'm just wrapping up glaze
to do serialization/deserialization, and if something fails (however it can fail) I return my own parse_error
consisting of error_code
and msg
. So I guess however much or little context can be given by glaze
, it'd be nice if the same format_error()
method can be reused (makes it easier to handle in generic code).
IMO it's totally fine if it just says "binary read error"
and "binary write error"
for the time being.
from glaze.
You're a trooper, thanks!
from glaze.
I was thinking about this the other day and I do think more information should be given about the error context for binary parsing. However, binary parsing errors should be extremely rare and not relied upon. I just added a warning comment about binary error checking to the documentation here.
Binary should not be written by hand and checksum mechanisms should be employed when sending across a network (or use protocols like TCP). The only way you would have parsing errors is if higher level validation and security mechanisms were broken or the code itself had errors (which is checked via unit testing). I have been adding more read parsing validation, but I'm undecided whether I should test all corner cases, because it causes a drop in performance for tests that shouldn't be needed if proper higher level safety mechanisms are used.
from glaze.
If you have an open API then you would need full checking, so I guess I'm convinced that there should be checks for all corner cases, except that some should be able to be turned off when used in a closed loop.
from glaze.
I've merged in support for your primary request. You can now handle parse_error
using buffers of std::byte
. The buffer context isn't given, but the index of the error is provided. The biggest benefit is that you can use glz::format_error
for both binary and json.
from glaze.
Related Issues (20)
- GLZ_FLATTEN adds significant compilation time on gcc. HOT 12
- host_include -> file_include -> fails parsing with `expected_comma`
- std::array<char> partial read handling HOT 10
- Binary (BEVE) support lacking for object keys HOT 8
- Type selection when reading to a variant HOT 1
- Update to v3.2.2 causes compilation errors HOT 9
- new_lines_in_arrays option should apply to writing JSON and not just prettify_json
- std::pair of structs fails round trip HOT 2
- Any struct with any members named "first" and "second" in any order is treated as a std::pair HOT 4
- can't write enum with the highest value HOT 4
- There seems to be an error. HOT 10
- Possible bug following examples in the README? HOT 2
- _GLIBCXX_DEBUG for libstdc++ cannot currently be used with glaze HOT 6
- Compilation error on 32-bit system HOT 6
- "expected_quote" Error in Variant Parsing with Unrelated JSON Key Length in glaze v3.3.1 HOT 2
- Disable exceptions if a specific macro is defined HOT 1
- AppleClang std::hash<std::filesystem::path> issue HOT 4
- Buffer length checking when writing to a raw buffer
- Runtime JSON pointer syntax for writing
- hang in glz::beve_to_json HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glaze.