Giter Club home page Giter Club logo

Comments (3)

codeinred avatar codeinred commented on May 13, 2024

Addendum: I just want to mention that this is particularly relevant in cases where nanosecond timestamps or integral numeric IDs are being stored in json. Nanosecond timestamps allow a bit of fuzzyness (if the timestamp is off by a microsecond, that's often not the end of the world), but 64-bit integral IDs need to match exactly

from glaze.

mwalcott3 avatar mwalcott3 commented on May 13, 2024

Yeah number parsing is going to change soonish (likely sometime next week). This will get fixed. Right now I would expect values between -2^53 to 2^53 would work properly since those should all be exactly representable. Values were originally parsed in as floating point numbers because we wanted to allow stuff like 1.7e10 which is handled by default in float parsers but typically not int parsers. We could quickfix this by parsing them as the proper type but it would break scientific notation and we are changing number parsing anyways.

I'm chilling in barbados right now but I'll fix this when I get back provided someone else doesn't get to it first. This is quite a big issue since as you pointed out 64bit hashes are broken when represent ed as ints as it's common for them to exceed the bounds of exactly representable ints in 64bit floating point numbers.

from glaze.

mwalcott3 avatar mwalcott3 commented on May 13, 2024

Fixed in 6e7cab3

from glaze.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.