stellar-deprecated / account-viewer Goto Github PK

Users signed in to their testnet account can't view balance. Add a tag indicating the account is on the testnet, not live net.

cc @irisli

https://github.com/stellar/stellar/issues/216

I've seen some reports about a security warning on Windows when using a Ledger Nano. TomLS commented on a reddit post with a Ledger help article indicating that this may be out of our control, but we should look into what we can do to fix it.

npm install fails when it tries to compile ed25519.

../src/ed25519.cc:10:49: error: no member named 'New' in 'v8::String'
        return ThrowException(Exception::Error(String::New(msg)));

Version:
npm 2.14.4
node v4.1.1

Steps to reproduce:

1. Add memo
2. Add AccountId

One might want to add the memo first just to make sure they don't forget the memo. But what happens is that doing it in this order makes the memo actually not be there, leading to sending a transaction missing its intended memo.

This seems like a common issue and we should check that:

1. User will have enough lumens to send
2. Recipient will receive enough lumens for funding if destination account is unfunded

Would you me amenable to a PR allowing the signed transaction XDR to be viewed before submitting it? This would allow you to use the account viewer even if multi-sig is enabled (letting you copy it so you can send it to another signer).

I'm thinking possibly of some expandable section or a dialog containing the XDR that opens when you press a link.

Ideally should let them log in but show 0 balance.

Should we say MEMO_NONE or No memo (or something else)?

MEMO_NONE is indeed a term used in code: https://github.com/stellar/stellar-core/blob/308540543c3b9f059fc50c06f74ec30b70e4ea0d/src/xdr/Stellar-transaction.x#L244

However, I wonder if it is the most user friendly.

account viewer should enable manually entering fees and have the default value set to what is being returned from /operation_fee_stats (stellar/go#586)

This will serve as reference implementation for other wallet developers and should prepare the community for potential future surge pricing scenarios.

This should take just a few minutes. Not all cultures have the same use for the comma and period so it would be nice to have one more visual cue of where the decimal is

We see so many users forgetting to set the memo when sending funds to exchanges like Bittrex and Kraken that we should consider displaying a warning when they try to do so. I've noticed stellarchain, stellar dashboard, and stellar expert all identify these exchanges (perhaps by home domain? or is this hard coded?).

If interstellar is truly discontinued, remove it's usage here. Update the build instructions so they don't use interstellar. It hasn't been updated for more than a year and it makes building this app problematic.

I'm planning on implementing Trezor support but I'm opening an issue for initial discussion and feedback before I begin coding.

This will also depend on an update to the Trezor Connect project which is being tracked by this issue: trezor/connect#127

As far as the actual implementation, I was planning on adding a "Sign in with Trezor" button under the "Sign in with Ledger" one and essentially copying the Ledger functionality.

Horizon 0.19.0 added join parameter that merges transaction data (including memo) into /payments response. This will improve loading time of memos in the payments history table.

646ca43

In the send pane, selecting a memo should update the placeholder in the input to the right of it.

Here are the requirements for memo: #12

It'd be really nice if we could link to account viewer following SEP-0007 to automatically fill in fields.

I think this used to work but I can't send to jedmccaleb*codetip.io

https://github.com/stellar/account-viewer/blob/master/controllers/send-widget.controller.es6

        let minimumBalance = 20 + (account.subentry_count) * 10;
        let nativeBalance = _(account.balances).find(balance => balance.asset_type === 'native').balance;
        let maxSend = new BigNumber(nativeBalance).minus(minimumBalance);
        if (maxSend.lt(this.amount)) {
          throw new BasicClientError('InsufficientBalanceError', {maxSend});
        }

We're not subtracting transaction fee from maxSend. Thanks @briangale for catching this!

Hi there,

I'm new to Stellar and wanted to contribute, but I can't seem to get it working. npm version is 5.6

account-viewer master % interstellar develop
events.js:136
      throw er; // Unhandled 'error' event
      ^

Error: spawn /usr/local/lib/node_modules/interstellar/bin/../../../node_modules/gulp/bin/gulp.js ENOENT
    at _errnoException (util.js:999:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:201:19)
    at onErrorNT (internal/child_process.js:389:16)
    at process._tickCallback (internal/process/next_tick.js:152:19)
    at Function.Module.runMain (module.js:703:11)
    at startup (bootstrap_node.js:194:16)
    at bootstrap_node.js:618:3
account-viewer master %

On medium screens (ex. 1440x900) app header and send widget fills the full screen size:

Some users may not notice transactions history (some browsers/systems don't show scrolls).

500000.0 XLM
should be displayed:
500,000.0 XLM

For maximum security it is best never to expose keys to an online machine, by generating wallets, and signing transactions completely offline. This client is very close to being able to do that, but doesn't quite work offline. If I download the page as a single file with all dependencies and scripts inlined using the plugin Save Page WE, the page loads but the buttons are non responsive - no errors display in the console. This is the file that is generated: https://ufile.io/w8s2r

It seems like enabling offline functionality is a few tweaks away, are there any plans to implement it?

Here is a bitcoin-centric tool implemented in such a fashion: https://coinb.in/

Online activities, like reading balances or broadcasting transactions could be optional.

Thanks.

1,000 instead of 1000 in balances and amount to send etc

Work in progress: https://github.com/stellar/account-viewer/tree/memo

Text and messages

No-memo state

Memo setup state

After Add memo is clicked, the memoSetup element appears and defaults to MEMO_TEXT

Memo setup with error state

Note: the text in this screenshot is out of date. Refer to the Text and messages section for the correct messages

Like what happened here: stellar/laboratory@bd0662e

It looks like Ledger connection timeouts if payment is not confirmed quickly. To reproduce:

1. Login using Ledger device.
2. Send 1 XLM to yourself.
3. Wait for 60 seconds in the Ledger device confirmation screen.
4. Confirm transaction in the Ledger device.

At this point, nothing happens and transaction is not signed.

I like the solution as created for #9 but on the sign-in page I'd like to be able to sign in to TestNet (for lots of purposes). Account-Viewer gives us developers a somewhat "official" way to demonstrate our code is doing the right thing (if I write some code on my laptop and someone can refresh their stellar.org Account-Viewer on TestNet view; and sees the appropriate changes reflected; that's a independent validation that the code actually worked).

As someone just cobbling together some first scripts; having these tools on TestNet would greatly improve those "I'm doing it right" validation moments for code/people looking at it through distributed endpoints.

Microsoft edge doesn't support EventSource and a polyfill is not readily available. In these situations, the user manually refreshes.

The times of automatic refresh are:

• during initial load
• after transaction included into consensus

Once the "the amount is invalid" error message comes up, it doesn't dismiss until the form is re-submitted. It should go away after the value is corrected.

https://github.com/chatch/stellar-hd-wallet

Hello!
I have a problem with building in Docker on Ubuntu/Alpine OS.
fsevetns supported only MacOS.
Is it possible to avoid this error on Ubuntu?

Module not found: Error: Can't resolve 'fs'

After reading this post and feeling bad for the guy I feel this change is trivial enough to save a lot of people having issues. Perhaps a simple styling for the private key and a warning message, an alert asking for confirmation. It's a one-liner.

Looks like it is requesting the account balance as fast as it can. It should use the streaming end point to get the account balance

"Try other more advanced Wallets" -> should link here: https://www.stellar.org/about/directory#wallets

I'm able to do this without errors in the send building. But if I submit this transaction, I get a OP_UNDERFUNDED.