Giter Club home page Giter Club logo

Comments (11)

eby avatar eby commented on July 22, 2024

Should be all set. Messed it up when I commented out some of the ssl stuff.

from docstore.

vielmetti avatar vielmetti commented on July 22, 2024

There was a report from Kai about some kind of "file too big" problem, investigating. That was a 135MB document.

from docstore.

eby avatar eby commented on July 22, 2024

I double-checked and Nginx is still 2G. If you have additional info on what the error was I can dig into it. Could be a timeout or something else

from docstore.

steiza avatar steiza commented on July 22, 2024

Aha! Tornado has a maximum upload size, but you can now customize it for the docstore app via max_file_size: in settings.yml. Note that the higher this is, the more memory the server will use!

I also updated docstore to use just Python 3. @eby if this is an issue I could add some backwards compatibility. Python 2 is end of life in 5 months, but I know all too well there's lots of Python 2 still out there!

from docstore.

eby avatar eby commented on July 22, 2024

Alright. It is up now with a 500M max_file_size to see how it does with memory. Also switched to python3. Let me know if you notice any issues @vielmetti

from docstore.

eby avatar eby commented on July 22, 2024

So again I'm not a python programmer. It looks like this has come up quite a bit. Not sure if the latest tornado already fixes the memory use but I found that there is a module to help buffer straight to disk so that memory isn't filled up: https://pythonhosted.org/tornadostreamform/

Supposedly bottle and flask already moved to a buffer to disk model when uploads are > small limit.

from docstore.

steiza avatar steiza commented on July 22, 2024

Yeah, tornado.web.stream_request_body looks promising, but from some quick investigation it looks like it might have some compatibility issues with XSRF cookies (at least in tornado 5).

from docstore.

vielmetti avatar vielmetti commented on July 22, 2024

I was able to upload http://a2docs.org/view/539 (about 130M) now with no issues.

I'll leave this issue open for you all to sort out if there should be any code changes (especially re tornado.web.stream_request_body) but am happy otherwise to close as "solved".

from docstore.

cdzombak avatar cdzombak commented on July 22, 2024

@vielmetti / @eby, can this ticket be closed out now?

from docstore.

steiza avatar steiza commented on July 22, 2024

I think someone should take a look at if tornado.web.stream_request_body (or something similar) could be used before closing this out.

from docstore.

vielmetti avatar vielmetti commented on July 22, 2024

Started a new #28 so this one can close.

from docstore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.