Giter Club home page Giter Club logo

Comments (7)

steiza avatar steiza commented on August 24, 2024

Ah, interesting. I pretty drastically simplified the sqlite data model, so there isn't currently a concept of document ids anymore.

The new route for downloading a doc is something like /file/<submission id>/<filename>. I could make a legacy mapping so /doc/<submission id>/view/<file id>/ redirects to /file/<submission id>/<filename>.

Do individual files need their own HTML page? Or do you just need a way to create a link to download the file?

from docstore.

eby avatar eby commented on August 24, 2024

One of the feature requests on the original was an online PDF or DOC viewer so documents could be viewed without downloading. Having a page per attachment might be beneficial for this type of thing going forward.

But it might just be something like /view/<submission id>/<filename> instead of having specific id's in the database.

from docstore.

steiza avatar steiza commented on August 24, 2024

This should be fixed by 7b88f6b, but it'll require some additional data to be added to the database. I'll send an email with details.

from docstore.

eby avatar eby commented on August 24, 2024

Rolled out the new code and the schema change and appears to work as expected

from docstore.

vielmetti avatar vielmetti commented on August 24, 2024

Thanks. I'll look at some of the URLs that are in the wild and make sure that they can be mapped properly so that no links break.

from docstore.

cdzombak avatar cdzombak commented on August 24, 2024

@vielmetti / @eby, can this ticket be closed out now?

from docstore.

vielmetti avatar vielmetti commented on August 24, 2024

I don't see any reason to keep it open after 3 years of idle; if it re-emerges as an issue we can reopen.

from docstore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.