Giter Club home page Giter Club logo

Comments (4)

Dendraspis avatar Dendraspis commented on June 1, 2024

Auto correct crop values is enabled by default which prevents such issues.
If you want it always to be mod 2, so why do you disable this feature?

Honestly, I don't get it. It's like turning the Auto Rotate feature off to complain, that nobody needs videos with wrong orientation and Auto Rotate should always be applied.

from staxrip.

noblemd00 avatar noblemd00 commented on June 1, 2024

Logically, why even have the Auto correct crop value switch IF A MOD 2 NUMBER IS ALWAYS REQUIRED. StaxRip should use the proper value to prevent the user receiving an ERROR message or having improper crop values filled.

Its like installing a light switch in your house that if turned off, it may explode a bomb. Why install such a switch?

StaxRip = (unselected option) calculates Crop not equal to Mod 2 = ERROR, ERROR, ERROR = UNNECESSARY

StaxRip = (auto corrects) Crop (all the time) = Mod 2 = GOOD = NO ERROR

Why have an Auto correct Crop value switch when a proper Auto correct cropping value is ALWAYS REQUIRED? The Auto correct crop selection setting is superfluous - should be on all the time.

Yes, I know the switch is on by default - BUT - Why allow a user to create a situation where an error could occur - if the Mod 2 value is ALWAYS required, do not allow the user to change an item that will create an error. Proper programming prevents the possibility of user errors.

At the very least there should be a warning when the Auto correct crop value is unselected - Warning: unselecting may cause Crop to calculate incorrect values!

from staxrip.

Dendraspis avatar Dendraspis commented on June 1, 2024

You have a pretty annoying opinion about what StaxRip should do....

Its like installing a light switch in your house that if turned off, it may explode a bomb.

There is no bomb that explodes. You get a message, that the number of turned off lights does not match your settings/expectations, so you can adjust/fix that.
At first you should make sure, that what you do is correct. On top of that there are some features that can help you and the Assistant, that warns you at last.

Why install such a switch?

Because you can turn off that particular light ?!

StaxRip = (unselected option) calculates Crop not equal to Mod 2 = ERROR, ERROR, ERROR = UNNECESSARY
StaxRip = (auto corrects) Crop (all the time) = Mod 2 = GOOD = NO ERROR

What makes you believe, that there are no circumstances that allow odd crop values?

Why have an Auto correct Crop value switch when a proper Auto correct cropping value is ALWAYS REQUIRED?

Because it depends on the source, filters and settings.
Better question: Why do you turn it off when you want it to be enabled?

The Auto correct crop selection setting is superfluous - should be on all the time.

Therefore it is enabled by default.

if the Mod 2 value is ALWAYS required

That's the point: It is not.

Proper programming prevents the possibility of user errors.

Indeed, but the definition of proper is a bit wanky when it comes to hundreds of use cases, video formats, limitations, exceptions, ...

At the very least there should be a warning when the Auto correct crop value is unselected - Warning: unselecting may cause Crop to calculate incorrect values!

As stated in the README, StaxRip has a lot to offer, but it is designed to be your tool, not vice versa. When you disable a feature, you should know what you do. You also don't get a warning when you select a high CRF value for the encoder, that the result may look a bit clonky.
Harming users who know what they to cannot be the solution.

At first the feature is there because it helps most users. Therefore it is enabled by default. To let the users decide, if they want to use it or not, it is possible to disable it.

from staxrip.

noblemd00 avatar noblemd00 commented on June 1, 2024

What makes you believe, that there are no circumstances that allow odd crop values?

My original question:

Are there circumstances where non-Mod 2 numbers can be used in cropping?

Mod 2 numbers are always even numbers (re: Benoit Mandelbrot)

This is the right click item (help) message (see my original question-above):
240212 173836

240212 183054

I have tried every value of the Options/Image/Output Mod value (2, 4, 8, 16) and the Error message persists (or does the "forced output mod value" refer to something else?):
240212 152156

What makes you believe, that there are no circumstances that allow odd crop values?

Further explanation re: Original inquiry:

  1. If you'll read my original post you'll see I specifically ask that question as part of the first paragraph. "Why" and "Are there circumstances"

Why does StaxRip auto fill with non-Mod 2 numbers if the Crop function requires Mod 2 numbers? Are there circumstances where non-Mod 2 numbers can be used in cropping?

AND... (note the "IF" at the beginning)

If a MOD 2 number is always REQUIRED by the crop function, StaxRip should automatically prevent (in any circumstance) non-Mod 2 numbers from being filled irregardless of Auto correct crop value settings - this Auto correct should be executed by default. This includes the Dolby auto and the Crop menu visual crop function, which should only select Mod 2 values when moving sliders and when executing auto cropping. This should be done without other user intervention (such as failing to check Auto correct).

  1. I was trying to illicit a reason for the existence of the Auto correct crop switch. Only after I asked those questions did I put forward my reasons for wondering about the Auto correct crop setting.

  2. If StaxRip can determine there is an error with the crop number, then wouldn't it be better for StaxRip to correct the value (add or subtract 1) and notify the user of the value change - thereby avoiding an error situation?


Better question: Why do you turn it off when you want it to be enabled?

Better Question yet: Why can it be turned off when it should always be enabled? (if true - the gist of my original inquiry - and still not answered).

Original question summary: Should StaxRip auto correct improper values automatically? (Auto crop after opening, Auto crop boarders until proper aspect ratio is found, and Crop menu Auto crop - all should result with proper corrected values)?

Auto crop screen with non Mod 2 (ODD) result:
240212 144641

The proper (and need I say it polite) way to answer my original inquiry would have been to explain (if true) that non-Mod 2 numbers can be used in some circumstances, SUCH AS... (I still don't know if this is true - never answered).

If you read my original question it was presented in a very polite manner answering the form questions.

  1. the question - my inquiry - Description
  2. Expected behavior - why I was inquiring
  3. What caused the issue
    Not in any way shape or form confrontational or argumentative - simply answering the form questions.

I did not ridicule you or the StaxRip program - I inquired about what I thought was an issue - Original question summary: an unneeded Auto correct crop checkbox - an item that should always be enabled and should not be capable of being disabled because, disablement results in an error?

Please note: I think StaxRip is a great program - my only purpose for inquiries and feature requests is to improve the program.

Your response to my original inquiry (did not answer my original questions):

Auto correct crop values is enabled by default which prevents such issues.
If you want it always to be mod 2, so why do you disable this feature?

Honestly, I don't get it. It's like turning the Auto Rotate feature off to complain, that nobody needs videos with wrong orientation and Auto Rotate should always be applied.

Contained no answers or useful information!

from staxrip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.