AutoCrop ignores analyzed frames about staxrip HOT 20 CLOSED

I actually mentioned it here:
#559

But I guess I couldn't make clear that there are unusual frames that autocrop sees but ignores them.

Anyway, better late than never 🙂

from staxrip.

Thank you very much for fixing the bug. I'm really grateful for it.
I haven't had time to check, but I'm gonna do it soon.
I didn't want to post a spam comment, but it wasn't polite to just not say anything.

from staxrip.

Ah YES!
it works. perfectly.
I was trying with "auto crop" and it was returning incorrect values as before. But when I used the crop window, everything was fine.

from staxrip.

I'm sorry I missed your email. I just checked. Thank you very much. I'm gonna try it now.

from staxrip.

I had to check it:
This issue persists since v1.7 from 2017 or even longer! 😲

Fix will take a few days.

But I guess I couldn't make clear that there are unusual frames that autocrop sees but ignores them.

Indeed. 😅 And without those specific samples I still would believe, that there is no issue! 🙄
The problem is, that it works, depending on the sizes of every frame that was considered.

Additionally I don't (or didn't) know any non-IMAX-videos that use multiple aspect ratios within such a short time.
It seems I ran into this issue a few times within the last years, but I thought it was because the AutoCrop didn't catch those specific frames.

Interesting... definitely a good catch! 👍

from staxrip.

OK I replaced the exes and everything works fine. Thank you very much for everything.

from staxrip.

So the proper version will be released with v2.39.

I guess we can close this issue now...

PS: Would be nice if you could answer my question from the mail. 😅

from staxrip.

If you can tell me how to do that, without scanning every 50 frames (~2s)....

A more robust detection would have to scan ~720 to ~1800 frames per hour of video and that would take a lot of time.
In most cases 10 scans are enough, as long as you don't deal with IMAX or another techniques that change the aspect ratio. If you know it in advance, you can take care, otherwise you're screwed, that's right.

The best approach is to crop manually after checking different scenes. 😕

from staxrip.

Sometimes when I use crop window, I can see some fullscreen images between others. But still it doesn't care.
I used to use this window to check and correct the cropping process, but now that I have the "auto crop" option, I barely check.

There are lots of content that have weird frames in them. Some have forced subtitles on the blackbars.

What I'm saying is, there is still some fullscreen frames visible using the tool but it's not sensitive enough to realize it. Maybe just a warning would be enough for a through check by the user.
Also, if we can have more than 200 frames, it would be awesome.

I don't know if what I asked is possible, but I have to go for it.

from staxrip.

Sometimes when I use crop window, I can see some fullscreen images between others. But still it doesn't care.
There are lots of content that have weird frames in them. Some have forced subtitles on the blackbars.
What I'm saying is, there is still some fullscreen frames visible using the tool but it's not sensitive enough to realize it.

In case you can reproduce it, please try to create a sample or record it so I can see what happens - that would help extremely.
Basically the procedure works good and right now I can't imagine what's going wrong. 🤔

Maybe just a warning would be enough for a through check by the user.

There is always a possibility to miss some frames as long as you don't check every frame. So not sure if that helps or is necessary.

Also, if we can have more than 200 frames, it would be awesome.

That's doable, yeah. 😅

from staxrip.

Can I use the email in your profile to send the information about this problem?

from staxrip.

Yes, you can, whereas the preferred way to interact/chat is Discord. But if you don't use Discord, feel free to write an email.

from staxrip.

Okay, the sample is exactly what was needed so I can reproduce and test my modifications. There is definitely something wrong...

from staxrip.

Thank you. I've sent you another sample as well.

from staxrip.

Yeah, thanks. I guess I know why the auto crop goes crazy on your samples, but it's insane, that nobody discovered or mentioned it before - the detection hasn't changed for years. 🥴

from staxrip.

The new v2.38.6 works well with your sample files. Feel free to check other videos as well and let me know how it works, please.

Note: This update of course only fixes the implemented AutoCrop feature, which is executed when you use it within the Crop window - not the automatic one when autocropping a source after opening.

from staxrip.

Did you have the chance to run the new AutoCrop (the one, that is in the Crop window) on other files? Can you give me any feedback?

from staxrip.

Unfortunately, the bug is still there. I compared the hashes of AutoCrop.exe between v2.37.6 and 2.38.6 and it's the same file.

from staxrip.

Can you first test if the integrated AutoCrop, the one you start from the Crop window, works?

from staxrip.

Then you have made a mistake while extracting. StaxRip comes with AutoCrop v2.2, I have sent you AutoCrop v2.3. 🤔

from staxrip.