Giter Club home page Giter Club logo

Comments (12)

Dendraspis avatar Dendraspis commented on June 12, 2024 1

Unfortunately that can happen with such complex procedures and (almost) no testers. When I have tested the subtitle name and language parsing it worked, at least for the language names I used.

Not sure why French is not accepted, but using
movie.[fr-FR]{France}.srt
should work. Maybe there are too many French languages....

from staxrip.

Dendraspis avatar Dendraspis commented on June 12, 2024 1

Okay, so it would have worked for movie_{French]{France} as this is what StaxRip would extract, but I improved it a bit so it will also check for the part without _.

Should be available in the next version....

from staxrip.

Dendraspis avatar Dendraspis commented on June 12, 2024 1

Here we run into another settlement - and yes, totally forget to take care of the track name part of my example while focusing on the language. 🙄

I think it has always been that way, that there must be a space before {, probably to avoid issues with { being part of the file name, so that's way it doesn't work for you. With a space it looks like this:
image

The problem with extracting names from file names is, that there will always be situations, where the given solution does not work unless we choose patterns, that have almost no chance to become a regular part of a file name, for example:
movie.[fr-FR]{{%$(France)$%}}

Nevertheless I have modified it a bit and it will start parsing the track name from the first { in the file name without requiring a leading space.

from staxrip.

Zodler avatar Zodler commented on June 12, 2024 1

Thank you. It all works now. I now put a space before {

from staxrip.

Dendraspis avatar Dendraspis commented on June 12, 2024 1

v2.35.8 is a hotfix for the _DELAY-DoVi issue, that does not include any other changes.

so the parsing for subtitles and audio do not match! Are they 2 different functions?!

Up to v2.35.8 they were indeed different.

from staxrip.

Dendraspis avatar Dendraspis commented on June 12, 2024 1

The extraction part itself yes, but there are still differences when it comes to metadata, so the read out language could be used instead - depending on the audio or subtitle file.

from staxrip.

Zodler avatar Zodler commented on June 12, 2024 1

It's still about parsing! 😄

from staxrip.

Zodler avatar Zodler commented on June 12, 2024

Ok I did several tests and maybe I didn't follow the naming convention correctly. I didn't know you should use [fr] to get French.

However {} still doesn't work. Anything you put in the accolade should go into the track name.
movie.[fr]{France}
should set the track language to French and track name to France.

Right now it is not reading what is inside {}.

Unless you use another symbol to set the track name.

from staxrip.

Zodler avatar Zodler commented on June 12, 2024

staxrip 2.35.8

movie_[fr-CA]{Canada}.srt
only fr-CA is parsed not Canada name
movie_[fr-CA] {Canada}.srt (with space works)


movie_[fr-CA]{Canada}_DELAY 1000ms.aac
[fr-CA] is not parsed (unlike subtitle) but Canada name is set (unlike subtitle again)

so the parsing for subtitles and audio do not match! Are they 2 different functions?!

from staxrip.

Zodler avatar Zodler commented on June 12, 2024

They will be the same in the future releases?

from staxrip.

Zodler avatar Zodler commented on June 12, 2024

Just a question. Can we currently pass the Gain level in an audio file name?

from staxrip.

Dendraspis avatar Dendraspis commented on June 12, 2024

As far as I remember no, because GAIN is not a property that is or can be extracted.
But we should stick to the topic. 😅

from staxrip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.