There are a few security and code quality tools out there at the moment that we should consider for our contracts. There is a great list of existing tools here.

On iOS at least, the name is automatically capitalized. This is an issue as most users won't notice this and fail to use their name.

On iOS it only works when validating using keyboard return. The Done button is not functional.

ENS DApp should rely on Status API to automatically fill necessary information.

From my understanding of this Identity implementation, since approval requires the current nonce to be equal to the nonce the execution request was stored with, if multiple execution attempts are made (all pointing to the same nonce) after the first approval the current nonce will increase, rendering all subsequent approvals on other pending executions to fail. Am I correct? And if so, is this the desired behavior?

I am trying to work out what is the appropriate way to sign offline for the _messageSignatures, in callGasRelayed(...), in IdentityGasRelay.sol.
The params dev instruction states "rsv concatenated ethereum signed message". Which web3 "signing" method is used to arrive at these r,s and v values? As I understand, these change with the encodings and

We have:
bytes32 signHash = getSignHash( callGasRelayHash( _to, _value, keccak256(_data), _nonce, _gasPrice, _gasLimit, _gasToken ) );

Where callGasRelayHash is:
_callGasRelayHash = keccak256( address(this), CALL_PREFIX, _to, _value, _dataHash, _nonce, _gasPrice, _gasLimit, _gasToken );

and getSignHash is:
signHash = keccak256("\x19Ethereum Signed Message:\n32", _hash);

so inline, the signHash is equivalent to:
keccak256("\x19Ethereum Signed Message:\n32", keccak256( address(this), CALL_PREFIX, _to, _value, keccak256(_data), _nonce, _gasPrice, _gasLimit, _gasToken ) )

Signatures included in _messageSignatures are eventually checked against this signHash using ecrecover, which takes the r,s and v values after extraction from _messageSignatures.
If the desired transaction to be relayed is of form:
var tx = { _to, _value, _data, _nonce, _gasPrice, _gasLimit, _gasToken }
How best to sign it offchain so the caller of callGasRelayed() has the correct _messageSignatures?

In the status-im/status-mobile#5648 we updated Status JS API.
We need to update ENS Dapp accordingly to use new API to access contact public key (when user allow it) so it would be pre-polutated in the Your contact code editbox

Steps to reproduce:

1. In Status App set to Ropsten network open latest version of the ENS Dapp( https://ipfs.infura.io/ipfs/QmfPPPvFMrPbprhbUexdRKomUnSDh9NsTx2Z6fVAsHeWNb/ is the latest at 29th of August 2018)
2. On the Pop-Up asking to grand access to profile tap 'Allow'
3. Tap 'Let's Go' button
4. Search for unique ens name
5. Check whether Your contact code field pre-populated with the public key of your current account

TF session with video for above steps: https://app.testfairy.com/projects/4803622-status/builds/8572662/sessions/4399737300/?accessToken=j0GveCm9d6c32KjurldJu-iefHk

With git checkout 000-snt-voting-dapp there appears to be some tests that are deprecated using Embark 3.1.2:

embark test
...
EmbarkSpec & deployAll are not supported anymore
You can learn about the new revamped tests here: https://embark.status.im/docs/testing.html

> ag EmbarkSpec
test/controlled.js
9:            EmbarkSpec.deployAll(contractsConfig, async function(accounts) {

test/DelegationProxyTest.js
43:          EmbarkSpec.deployAll(contractsConfig, async function(accountsArr) {

test/erc20token.js
9:        EmbarkSpec.deployAll(contractsConfig, async function(accounts) {

test/testtoken.js
12:    EmbarkSpec.deployAll(contractsConfig, async function(accounts) {

test/minimetoken.js
27:    EmbarkSpec.deployAll(contractsConfig, async function(accountsArr) {

See embarklabs/embark#548

Acceptance criteria

Make embark test green again with latest version of Embark.

On some screen sizes (iPhone8) the register button of search screen is hidden by the wallet address.