Giter Club home page Giter Club logo

Comments (4)

dstpierre avatar dstpierre commented on August 23, 2024

We will take this opportunity to create a public API function to get multiple documents at once from an array of IDs.

Function could be called GetDocuments and receive a []string of ids.

I'd add this to the Persister interface and implement in the 3 database implementation (postgresql, mongo, and memory).

This function would return a []map[string]any

In db.go line:44:

if len(parts) == 4 {
  database.list(w, r)
} else {

I'd check for the presence of the query string byids=1 and create a new function that would get the IDs via the posted body which will be an array if string:

url example: /db/tasks?byids=1
body: ['id1-here', 'id2-here', '...']

Once this is implemented, we will be able to use this in the bulk update to publish all updated documents.

Also once #27 is completed for the delete un bulk, we'll re-use this same concept to publish the deleted document event for all deleted docs.

Let me know if I'm missing something and you think of something else in implementation.

from core.

rostikts avatar rostikts commented on August 23, 2024

@dstpierre IMO the GET request with the body is a bad practice. Maybe it would be better to pass the ids in the query params?
url example /db/tasks?ids=id1,id2,id3

from core.

dstpierre avatar dstpierre commented on August 23, 2024

@rostikts yep totally. although the query string is limited to 1024 characters.

I wonder if using a POST would be more flexible.

Also I'm doing a major refactor of the internal package in #58 - there will be a lot of conflict as I'm moving most of the struct and interface out of the internal package. Not a huge issue if you've already started.

from core.

dstpierre avatar dstpierre commented on August 23, 2024

@rostikts just wanted to let you know that the PR #58 is now merge, so it's safe to resume your work for this issue if you'd like.

The internal package is mostly gone, and a new model package replace it.

Let me know if there's any issues.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.