Comments (2)
Possibly separated package it too much
Later I'll try to implement this staff in exposed.go
from core.
Hey there, I'm not sure I fully understand what you're proposing.
Those expored functions are already just wrapper around existing functionalities. Take the Emailer.Send
you just added, the glue code is to handle the translation between goja types and Go's, that's mostly it.
I'm not sure I see the benefits of moving that glue code outside the function
package.
Maybe having a file in the function
package with all that glue code, removing it from runtime.go
, say something like exposed.go
(for lack of better word for now haha) and moving all those env.addX
there and have one function call from the Execute
function say: env.setuop()
or whatever.
This could be a nice refactor. Can you showcase what you're referring to by having them in their own package, can you give an example for instance of what could be customized?
from core.
Related Issues (20)
- Ensure 3rd-party s3 compatible storage works HOT 1
- Enable grpc based clients HOT 2
- token creation datetime not saving correctly in database HOT 1
- Feature: GetTenantByEmail function HOT 1
- Implement a SQLite provider
- Implement a full-text search capability
- Embed UI templates via go:embed HOT 9
- Database provider tests clean-up
- [backend-js] Build an additional bundle importable via <script> tag HOT 1
- [core & cli] Save dev database between CLI restart HOT 1
- [docs] A tutorial for Next.js
- Add email interface to server-side function runtime HOT 13
- [cli] Add a tail command to follow server logs HOT 3
- Clean-up backend package test
- Using environment variables from .env file under vscode HOT 2
- Schedule task improvments
- [backend-dart] Create a client library for Dart HOT 5
- review quick start for backend client library (go doc) HOT 1
- Add / remove user from account
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.