Giter Club home page Giter Club logo

Comments (2)

g41797 avatar g41797 commented on July 21, 2024 1

Possibly separated package it too much
Later I'll try to implement this staff in exposed.go

from core.

dstpierre avatar dstpierre commented on July 21, 2024

Hey there, I'm not sure I fully understand what you're proposing.

Those expored functions are already just wrapper around existing functionalities. Take the Emailer.Send you just added, the glue code is to handle the translation between goja types and Go's, that's mostly it.

I'm not sure I see the benefits of moving that glue code outside the function package.

Maybe having a file in the function package with all that glue code, removing it from runtime.go, say something like exposed.go (for lack of better word for now haha) and moving all those env.addX there and have one function call from the Execute function say: env.setuop() or whatever.

This could be a nice refactor. Can you showcase what you're referring to by having them in their own package, can you give an example for instance of what could be customized?

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.