startersclan / bf2stats Goto Github PK

Current

Separate nginx and php images (for both ASP and bf2sclone)

Expectation

Single image containing nginx and php. (for both ASP and bf2sclone)

Discussion

Currently the nginx and php are in separate images.

Benefits:

• Separation of concerns principle
• Independent scalability of nginx and php
• Better security

Drawbacks:

• More difficult to deploy. Requires two separate containers to serve one application. Application does not work until both containers have started
• More difficult to upgrade, since two tags must be bumped
• Environment variables for the PHP application are specified only on the PHP container only, which is confusing
• nginx.conf config file requires hostname of php, which means that either: 1) nginx container may require an env variable like PHP_HOSTNAME which overrides a value in nginx.conf (which is not conventional and difficult to understand), or 2) user needs to use a custom nginx.conf. Instead, if they were in the same container, 127.0.0.1 may simply be used.