starkbank / ecdsa-java Goto Github PK

Considering using these libraries but I don't see a LICNESE file in each repo. Could you add a LICENSE for the Java, PHP, Ruby, and Node libs and include in a new release?

@test
public void testSign() {
PrivateKey privateKey = new PrivateKey();
String message = "This is a text message";
long a = System.nanoTime();
for (int i = 0; i < 100; i++) {
Ecdsa.sign(message, privateKey);
}
long b = System.nanoTime();
System.out.println((b - a) / 1000000);
}

I just tried to get string representation of the Secret key and have got unexpected result:
Both methods:
ByteString bStr = privateKey.toByteString();
String res = BinaryAscii.hexFromBinary(bStr);

and:
String res = privateKey.secret.toString(16);

return some thing like this:

4b2e90b5a1044c47853924d138c033bf0ff8c73ec0bce4bef513c75ae5e57ddb0c
which differs in length with expected size (32 bytes) by one byte.

Explanations of correct use are highly appreciated.
Kind regards.

In Maven Central the group id is "com.starkbank.ellipticcurve" not "com.starkbank" as you specify

The Oracle java is not support java.lang.Math.multiply and java.lang.Math.add

thanks

Hi Team

Thanks for sharing your work in public. I took the code and added specification for NIST secp521r1 curve in the code and ,measured the performance for (ECDSA) Signature Verification. I got around 400 Signature verification.

Also when I saw your performance for secp256k1 curve

Library | sign | verify

java.security | 0.9ms | 2.4ms
starkbank-ecdsa | 4.3ms | 9.9ms

If I am correct. The java.security is performing 4 times better than your version?
Any thoughts

Request a method for using Public Key Hex to verify signatures.

Can this support ECDAA, is there a connection ?