Giter Club home page Giter Club logo

stark-sketch-plugin's People

Contributors

imcatnoone avatar mfouquet avatar vgpena avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

stark-sketch-plugin's Issues

Feature Request: Non-text Contrast simulation

WCAG 2.1. introduced 'Non-text Contrast' as a Success Criterion. It applies to custom designs for controls. These controls often consist of a variety of elements. The guideline states
"[…] visual information required to identify user interface components and states […]" need to achieve at least a 3:1 contrast ratio for the success criterion to be met.
( https://www.w3.org/WAI/WCAG21/Understanding/non-text-contrast.html )

We just learned that a helpful way to quickly figure out whether a design meets this criterion is to get rid of all the parts with contrast below the 3:1 ratio and check whether the remaining parts are sufficient to let users see and understand the control, it's state and purpose.

While this is for sure not bullet-proof, I think it might be helpful tool for people working on more inclusive designs. I'd love to see something like this to be available as a feature of Stark. (Love this plugin btw., so helpful!)

For illustrative purposes, here's a quick and dirty simulation made with two layers in Sketch:
image

non-text-contrast.sketch.zip

Contrast check for color against background

First of all thanks for building this! I really like how easy it is to use, no more excuses for not doing these checks.

When checking type against a background, Stark currently matches the color of the text against the color of the shape. I think matching the color of the text against the background color of the shape would be better behaviour, since that’s often what you want. Maybe like so:

  • Use color for text layers.
  • Use background color for all other layer types.
  • If the layer does not have a background color, use border-color when present.

I’m not familiar with programming Sketch plugins so I don’t know if this is at all possible, but it would be nice.

Easy way to toggle through all color modes

Hey, pretty fantastic plugin! 👍

it would be pretty if you could add shortcut to go to the next / previous color blindness mode. This would make it easy to toggle through them quickly to check where you have issues.

Thanks.

Color Contrast with Opacity

Firstly, thanks so much for creating and supporting this plugin! It's incredible to have the color contrast and color deficiencies in one tool.

When selecting 2 layers (text and a background color with opacity), I noticed the color contrast is calculated on the full opacity version of each's colors. Could a future enhancement take into account opacity, or even better yet — calculate the optical result of any number of layers, including just 1 over an artboard color? (This is in another request as the ultimate goal, but may be necessary for calculating the resulting color of what that translucent layer's color turns into.)

Feature Request: Instead of requiring two layers in a selection, when selecting one object, it would be good if "white" was a default second layer.

When checking the accessibility of a colour, most times at a default I want to see if it's either accessible against white or black.

I thought this was an option with the previous version of Stark? I may be mistaken though.

Regardless, if instead of having two layers selected as a default, it would be good if "white" (or black) could be a "pseudo-selection" if only one layer is selected.

Does that make sense?

Widget Size

It is a great tool. It would be even better if it was more compact and we had more control over the size of the window. It takes a lot of screen real estate. Especially the contrast checker.

Feature Request: Old colorblind simulation style

Edit: Forgot to say that I love this tool and use it pretty much everyday!

I frequently used the old version to quickly compare color options in the colorblind simulator across multiple artboards. I am unable to do this now with the new design, it's impossible to quickly compare two artboard options as the simulation type resets when I change artboards but even if it kept the simulation type, I would find it much harder to compare by swapping vs side by side. I find the tool much less valuable because of the update. Would it be possible to add the option to use the old colorblind simulation?

Exported must not contain color profile

If the exported PNG from Stark preview contains a color profile. The results viewed in (some) web browsers or other computers might differ dramatically from the real view.

I see this strange result when viewing the png in Chrome browser.

Support Sketch 45 plugin update system

Hi there!

This is a quick note to remind you that Sketch 45 will include a plugin update system.

It would be awesome if you could add support to it (it's really easy!) before Sketch 45 comes out. Ideally, you should release an update for your plugin while we're still in Sketch 44, so your users will have a nice & easy experience when 45 is released.

For more details, please check http://sketchplugins.com/d/229-updating-plugins and http://developer.sketchapp.com/introduction/updating-plugins/

Thanks in advance!

Request: indicators of most common color blindness types

Love the color blindness feature preview! I've noticed some other color blindness preview tools indicate which color blindness types are the most common in the selector (Deuteranomaly (6% of males), Protanomaly (1%), Deuteranopia (1%), Protanopia (1%)).

Though I usually see it marked qualitatively in other apps ("Common", "Rare", "Very Rare").

I thought something in this vein might be useful for those who are less familiar with the different types.

Stark fails to open

Frequently having an issue where Stark fails to open – typically after I've used it once. Steps to reproduce:

  1. Open Sketch and begin working
  2. Open Stark (either via Runner or through the menu option)
  3. Stark works successfully
  4. Close Stark
  5. Open Stark again to check another element
  6. Nothing happens

Using:
Sketch 49.2
MacOs: High Sierra
Stark: 1.6

Color Contrast first?

Again, thanks so much for creating and supporting this plugin! It's incredible to have the color contrast and color deficiencies in one tool.

I'm not sure of others' needs, but my team more often tests color contrast than color deficiency. Would it be possible to default to the color contrast tool, rather than color deficiency? Or allow it to do so via a setting?

Visual contrast simulator

While the contrast checker is currently as complete as other tools I've seen, a visual approach similar to the color blindness mode I think would be more useful and quicker to use. If you've used the NoCoffee simulator for web pages, that's essentially the set of simulation effects I'd like to use when checking a design.

Additionally for the numeric contrast results, it would be great to have:

  1. A manual spot check (two draggable, zoomed targets?) that updates in realtime.
  2. Automatic highlighters (color fills or outlines) for all areas of the view which won't meet AA and AAA ratios, respectively.

Stark creating Uncommited changes when used

Whenever I use the awesome plugin it generates a snapshot and a js file that is automatically added as an uncommitted change in my git client. Can this be fixed so that I don't have to push changes or discard them before pulling a fresh version? Or any other workaround?

Will this issue go away if I install through i.e Runner?

Stark Sketch plugin won’t update

Howdy awesome Stark folks!

A user reached out via our forums to report that they were having trouble updating your Plugin.

We checked the report and could replicate the issue. However, some things we did notice:

  • The Stark Plugin reports that there’s a new version 3.19.0 available
  • When inspecting the appcast.xml only 3.18.0 is specified as the latest one.
  • The releases page on this repository still points to a 3.18.0 version
Screenshot 2023-09-20 at 8 44 54 AM

Would you mind checking this on your end in case this is what is affecting the users of the plugin in Sketch? 🙏

Screenshot 2023-09-20 at 8 41 58 AM

Links

Plugin hangs on update

image

After clicking the udpate button nothing happens.
Restarting sketch does not resolve the issue

Does Stark round up contrast ratios?

Had an interesting discrepancy between the Stark Sketch plugin and our Storybook accessibility plugin. We were checking the contrast ratio for the color value #a96805. Stark gave it a passing rating of 4.5:1 where the storybook and the WebAIM checker fails the contrast ratio.

Screenshot from Stark

Screen Shot 2020-09-15 at 2 49 12 PM

Screenshot from WebAIM

image-20200916-152515

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.