starburstdata / error-prone-checks Goto Github PK

It doesn't warn overriding a method deprecated in the base class/interface.

A few ideas came up as I was trying to add a deprecated usage check.

• Do we really need 1 module per checker? Upstream has all checkers in core. We can probably just have a starburst-errorprone-checks with everything? Easier managing artifacts new checkers.
• We can parameterize the package prefixes? That'll make the checkers more generic. Plus we can gradually widen the checks as we fix warnings. http://errorprone.info/docs/flags

https://github.com/starburstdata/error-prone-checks/blob/main/trino-experimental-check/src/main/java/com/starburstdata/errorprone/check/trinoexperimentalspi/AnnotatedApiUsageChecker.java#L100

isInMatchingPackage here matches if the annotate symbol, i.e. the code being analyzed, is in io.trino.spi. So the tests actually fail if I move AnnotatedClass & ClassWithAnnotatedMember to com.starburstdata. Don't think that's desired? The checker we borrowed from checks if @Beta is used within Guava library code only, while in this case we want to check if io.trino.Experimental is used in com.starburstdata.*, or rather in any package.
https://github.com/google/guava-beta-checker/blob/master/src/main/java/com/google/common/annotations/checkers/BetaChecker.java#L53