starburstdata / dbt-trino-utils Goto Github PK

seems that those macros could not used with trino. Single quote should be double quote ?

Do we need to override this ?

https://github.com/dbt-labs/dbt-utils/blob/main/macros/generic_tests/equality.sql#L67
https://github.com/dbt-labs/dbt-utils/blob/main/macros/generic_tests/equality.sql#L69

Add dbt metrics package support

Describe the feature

I just tried to use dbt metrics, but it fails with trino, I think because of the following:
There's a dateadd in the metric_date_spine macro in the that trino doesn't recognize (it's date_add for trino).
Would it be an option to use this package to reimplement the macros necessary to run dbt metrics?

Describe alternatives you've considered

Overwrite the macros myself

Who will benefit?

People who want to use dbt metrics with trino.

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Some of the tests for dbt-metrics are disabled:

Fix and enable these tests. Add Trino shims if needed.

Upgrade dbt-trino-utils to v1.0.0 https://github.com/dbt-labs/dbt-utils/releases/tag/1.0.0-rc1

Add dbt-date package support

Patch regexp_instr for Trino, so that its compatible in dbt-expectations

Reference, of why am here.
calogica/dbt-expectations#243

Is your feature request related to a problem? Please describe.
Lets support regex expectation for Trino on
https://github.com/calogica/dbt-expectations/blob/b21b13f020f5df2c90885d0715a2e713d1204700/macros/regex/regexp_instr.sql

Describe the solution you'd like
We can use this,
https://trino.io/docs/current/functions/regexp.html
regexp_position(string, pattern, start, occurrence) → integer

Lets group similar implementation like https://github.com/dbt-msft/tsql-utils/tree/main/macros/dbt_expectations ?

Add test matrix for different dbt versions in CI/CD

Add release section in readme, as it is missing.

details here: #28 (comment)

Currently, most of the tests for dbt-date are disabled, as Trino-specific implementations for macros are needed:

There is small bug in macros/dbt_utils/sql/deduplicate.sql:

1. Comparison operator is wrong, fix it.
2. Some new test could be written, as current test implemented in dbt-utils is not adequate to our implementation of deduplicate macro, because rn column is leaking due to lack of natural join in trino (trinodb/trino#14455).
3. Investigate if there is a way to bypass/workaround/implement in another way, that rn won't be leaking.

Fix dbt-project-evaluator, some models and seeds are overridden at integration-tests level, but should be at package level