Giter Club home page Giter Club logo

boeing-wave4-knowledgehub's People

Contributors

aishwarya-ga avatar akshayvb66 avatar gauravgkp avatar komal148 avatar meghana-n avatar meghnaw19 avatar naneeth avatar ratnaurvashi avatar santhoshtn avatar sushmitha007 avatar udayn612 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

boeing-wave4-knowledgehub's Issues

Give proper http status

content-extractor/src/main/java/com/stackroute/controller/PdfController.java

public ResponseEntity getFile(@PathVariable String filename) throws TikaException, SAXException, IOException, FileNotFoundException, EmptyFileException {
System.out.println(filename);
try {
String jsonString = contentExtractionService.extractFromFile(path);
kafkaTemplate.send(TOPIC,jsonString);
return ResponseEntity.status(HttpStatus.OK).body(jsonString);

        } catch (Exception e) {
            String message = filename + " is not available";
            return ResponseEntity.status(HttpStatus.CONFLICT).body(message);
        }

Incorrect autowiring

login-service/src/main/java/com/stackroute/controller/AuthRestAPI.java

login-service/src/main/java/com/stackroute/controller/AuthRestAPI.java

@Autowired
AuthenticationManager authenticationManager;

@Autowired
UserRepository userRepository;

@Autowired
PasswordEncoder encoder;

@Autowired
JwtProvider jwtProvider;

Remove hard coded string

content-extractor/src/main/java/com/stackroute/service/PdfExtractionServiceImpl.java

        throw new FileNotFoundException("File Not Found !! ");
        throw new EmptyFileException("File is Empty");

Remove hardcoded values

nlp-service/src/main/java/com/stackroute/service/NlpServiceImpl.java

String stopwords[] = {"i", "me", "my", "myself", "we", "our", "ours", "ourselves", "could", "he'd",
"he'll", "he's", "here's", "how's", "ought", "she'd", "she'll", "that's", "there's", "they'd",
"they'll", "they're", "they've", "we'd", "we'll", "we're", "we've", "what's", "when's", "where's",
"who's", "why's", "would", "i'd", "i'll", "i'm", "i've", "you", "you're", "you've", "you'll",
"you'd", "your", "yours", "yourself", "yourselves", "he", "him", "his", "himself", "she",
"she's", "her", "hers", "herself", "it", "it's", "its", "itself", "they", "them", "their",
"theirs", "themselves", "what", "which", "who", "whom", "this", "that", "that'll", "these",
"those", "am", "is", "are", "was", "were", "be", "been", "being", "have", "has", "had", "having",
"do", "does", "did", "doing", "a", "an", "the", "and", "but", "if", "or", "because", "as", "until",
"while", "of", "at", "by", "for", "with", "about", "against", "between", "into", "through",
"during", "before", "after", "above", "below", "to", "from", "up", "down", "in", "out", "on",
"off", "over", "under", "again", "further", "then", "once", "here", "there", "when", "where",
"why", "how", "all", "any", "both", "each", "few", "more", "most", "other", "some", "such", "no",
"nor", "not", "only", "own", "same", "so", "than", "too", "very", "s", "t", "can", "will",
"just", "don", "don't", "should", "should've", "now", "d", "ll", "m", "o", "re", "ve", "y", "ain",
"aren", "aren't", "couldn", "couldn't", "didn", "didn't", "doesn", "doesn't", "hadn", "hadn't",
"hasn", "hasn't", "haven", "haven't", "isn", "isn't", "ma", "mightn", "mightn't", "mustn", "mustn't",
"needn", "needn't", "shan", "shan't", "shouldn", "shouldn't", "wasn", "wasn't", "weren", "weren't",
"won", "won't", "wouldn", "wouldn't"};

Move it to properties file

Give proper comments

login-service/src/main/java/com/stackroute/controller/TestRestAPI.java

//this controller class is used for testing the authentication
it should be //To test the authentication

Remove print statements

content-extractor/src/main/java/com/stackroute/controller/PdfController.java

        System.out.println(filename);

Remove commented code

content-extractor/src/main/java/com/stackroute/service/PdfExtractionServiceImpl.java

// Gson gson = new Gson();
// String jsonString = gson.toJson(pdfDocument);

No comments

paragraph-tokenizer/src/main/java/com/stackroute/controller/ParagraphController.java

Remove commented code

login-service/src/main/java/com/stackroute/domain/User.java

// public User() {}

// public User( String username, String password) {
//
// this.username = username;
//
// this.password = password;
// }

// public Long getId() {
// return id;
// }
//
// public void setId(Long id) {
// this.id = id;
// }
//
// public String getUsername() {
// return username;
// }
//
// public void setUsername(String username) {
// this.username = username;
// }
//
//
// public String getPassword() {
// return password;
// }
//
// public void setPassword(String password) {
// this.password = password;
// }

Give comments

nlp-service/src/main/java/com/stackroute/service/NlpServiceImpl.java

Incorrect parent

nlp-service: pom.xml

org.springframework.boot spring-boot-starter-parent 2.1.2.RELEASE

Incorrect autowiring

content-extractor/src/main/java/com/stackroute/controller/PdfController.java

@Autowired
PdfExtractionServiceImpl contentExtractionService;

    @Autowired
    private KafkaTemplate<String, String> kafkaTemplate;

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.