boeing-wave4-knowledgehub's People
Forkers
gattinenirohini66 iamanuragratna farhaan900 ankiitaa somee-15 svnsairam meghnaw19 gauravgkp ykroshan sushmitha007boeing-wave4-knowledgehub's Issues
paragraph-tokeniser: pom.xml: Incorrect parent tag
Incorrect package naming
content-extractor/src/main/java/com/stackroute
Exception should be exception
paragraph-tokenizer: ParagraphServiceImpl.java: Exceptions not handled
login-service: AuthRestAPI.java: Add comments
Give proper http status
content-extractor/src/main/java/com/stackroute/controller/PdfController.java
public ResponseEntity getFile(@PathVariable String filename) throws TikaException, SAXException, IOException, FileNotFoundException, EmptyFileException {
System.out.println(filename);
try {
String jsonString = contentExtractionService.extractFromFile(path);
kafkaTemplate.send(TOPIC,jsonString);
return ResponseEntity.status(HttpStatus.OK).body(jsonString);
} catch (Exception e) {
String message = filename + " is not available";
return ResponseEntity.status(HttpStatus.CONFLICT).body(message);
}
No readme present
nlp-service
No test cases present
login-service
No test cases present
nlp-service
Global: Write test cases, handle exceptions, add comments, proper indentation, correct http status for your microservice
Remove unrequired files
Move it to .gitignore
Incorrect autowiring
login-service/src/main/java/com/stackroute/controller/AuthRestAPI.java
login-service/src/main/java/com/stackroute/controller/AuthRestAPI.java
@Autowired
AuthenticationManager authenticationManager;
@Autowired
UserRepository userRepository;
@Autowired
PasswordEncoder encoder;
@Autowired
JwtProvider jwtProvider;
content-extractor: pdfController.java: Add comments
Remove .coveralls.yml
Incorrect request mapping method
content-extractor/src/main/java/com/stackroute/controller/PdfController.java
@PostMapping("/post")
parent pom: remove unused modules from pom
<module>eventbrite-service</module>
Remove hard coded string
content-extractor/src/main/java/com/stackroute/service/PdfExtractionServiceImpl.java
throw new FileNotFoundException("File Not Found !! ");
throw new EmptyFileException("File is Empty");
Remove hardcoded values
nlp-service/src/main/java/com/stackroute/service/NlpServiceImpl.java
String stopwords[] = {"i", "me", "my", "myself", "we", "our", "ours", "ourselves", "could", "he'd",
"he'll", "he's", "here's", "how's", "ought", "she'd", "she'll", "that's", "there's", "they'd",
"they'll", "they're", "they've", "we'd", "we'll", "we're", "we've", "what's", "when's", "where's",
"who's", "why's", "would", "i'd", "i'll", "i'm", "i've", "you", "you're", "you've", "you'll",
"you'd", "your", "yours", "yourself", "yourselves", "he", "him", "his", "himself", "she",
"she's", "her", "hers", "herself", "it", "it's", "its", "itself", "they", "them", "their",
"theirs", "themselves", "what", "which", "who", "whom", "this", "that", "that'll", "these",
"those", "am", "is", "are", "was", "were", "be", "been", "being", "have", "has", "had", "having",
"do", "does", "did", "doing", "a", "an", "the", "and", "but", "if", "or", "because", "as", "until",
"while", "of", "at", "by", "for", "with", "about", "against", "between", "into", "through",
"during", "before", "after", "above", "below", "to", "from", "up", "down", "in", "out", "on",
"off", "over", "under", "again", "further", "then", "once", "here", "there", "when", "where",
"why", "how", "all", "any", "both", "each", "few", "more", "most", "other", "some", "such", "no",
"nor", "not", "only", "own", "same", "so", "than", "too", "very", "s", "t", "can", "will",
"just", "don", "don't", "should", "should've", "now", "d", "ll", "m", "o", "re", "ve", "y", "ain",
"aren", "aren't", "couldn", "couldn't", "didn", "didn't", "doesn", "doesn't", "hadn", "hadn't",
"hasn", "hasn't", "haven", "haven't", "isn", "isn't", "ma", "mightn", "mightn't", "mustn", "mustn't",
"needn", "needn't", "shan", "shan't", "shouldn", "shouldn't", "wasn", "wasn't", "weren", "weren't",
"won", "won't", "wouldn", "wouldn't"};
Move it to properties file
analytic-service: pom.xml: Incorrect parent tag
Give appropriate access specifiers
content-extractor/src/main/java/com/stackroute/controller/PdfController.java
String path;
Incorrect directory structure
paragraph-tokenizer/src/
Give proper comments
login-service/src/main/java/com/stackroute/controller/TestRestAPI.java
//this controller class is used for testing the authentication
it should be //To test the authentication
Remove print statements
content-extractor/src/main/java/com/stackroute/controller/PdfController.java
System.out.println(filename);
Remove the Dead Code/ commented Code
No readme present
paragraph-tokenizer/
Remove commented code
content-extractor/src/main/java/com/stackroute/service/PdfExtractionServiceImpl.java
// Gson gson = new Gson();
// String jsonString = gson.toJson(pdfDocument);
No comments
paragraph-tokenizer/src/main/java/com/stackroute/controller/ParagraphController.java
Incorrect directory structure
content-extractor/src
test/java
login-service: User.java: No use of lombok
Give appropriate http status
paragraph-tokenizer/src/main/java/com/stackroute/controller/ParagraphController.java
Remove commented code
login-service/src/main/java/com/stackroute/domain/User.java
// public User() {}
// public User( String username, String password) {
//
// this.username = username;
//
// this.password = password;
// }
// public Long getId() {
// return id;
// }
//
// public void setId(Long id) {
// this.id = id;
// }
//
// public String getUsername() {
// return username;
// }
//
// public void setUsername(String username) {
// this.username = username;
// }
//
//
// public String getPassword() {
// return password;
// }
//
// public void setPassword(String password) {
// this.password = password;
// }
Give comments
nlp-service/src/main/java/com/stackroute/service/NlpServiceImpl.java
Incorrect directory structure
nlp-service
test/java/com/stackroute
content-extractor: pdfController.java: Incorrect class naming convention
No .README present
login-service/
paragraph-tokenizer: No parent tag present
Incorrect parent
nlp-service: pom.xml
org.springframework.boot spring-boot-starter-parent 2.1.2.RELEASENo test cases present
content-extractor
paragraph-tokenizer: no Dockerfile present
parent pom: add required modules in pom
Incorrect folder naming
Extractor
remove the dist/ from the root of the angular
paragraph-tokenizer: pom.xml: Incorrect versions
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
Global: Move hard coded strings to properties file
Add all the backend urls in the environments file
login-service: Convert application.properties to application.yml
Incorrect package naming convention
analytic-server/src/main/java/com/stackroute/
Config should be config
docker-compose.yml: add required services in compose
content-extractor: ContentExtractionServiceImpl: Remove print statements
Incorrect autowiring
content-extractor/src/main/java/com/stackroute/controller/PdfController.java
@Autowired
PdfExtractionServiceImpl contentExtractionService;
@Autowired
private KafkaTemplate<String, String> kafkaTemplate;
content-extractor: pdfController.java: Remove print statements
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.