st-one-io / node-red-contrib-df1 Goto Github PK

After the update to version 1.1.1, to include events propagation to node-red-contrib-df1-gateway, those kind of warning messages are often appearing:

(node:4281) UnhandledPromiseRejectionWarning: Error [ERR_UNHANDLED_ERROR]: Unhandled error. (undefined)
     at DF1Endpoint.emit (events.js:364:17)
     at DF1Endpoint.Node.emit (/opt/st-one-node-red/node-red/node_modules/@node-red/runtime/lib/nodes/Node.js:185:20)
     at onError (/home/node-red/node_modules/node-red-contrib-df1/red/df1.js:306:18)
     at /home/node-red/node_modules/node-red-contrib-df1/red/df1.js:150:21
     at runNextTicks (internal/process/task_queues.js:60:5)
     at listOnTimeout (internal/timers.js:526:9)
     at processTimers (internal/timers.js:500:7)

We should think of better approaches to avoid those messages.

After the version 1.1.1 the node seems to be having issues when updating it's connection status on Node-RED.

Steps to reproduce

I was connected to the Micrologix 1400 with a malfunctioning cable on the mini-DIN port. After setting some variables for collection the df1 in node was not outputting any variables and neither changing it's connection status (always online).

I downgraded to version 1.0.1 and the node also didn't output any variables, but this time a timeout error appeared on the debug panel and the status changed to offline.

Since @protocols/node-df1 is now an optional dependency, the code should always check if the required module can indeed be used.

See optionalDependencies on npm documentation for further explanation.