ssbeefeater / axios-request Goto Github PK

Would be great if this library had typing support with Typescript.

Thought it was a bit much to make a PR for 1 char.

In your documentation is says:

requestInstance.isPending(method = '') // returns true when a request is on the fly
requestInstance.isUpdating(method = 'post') // returns true when a request is on the fly after interval request
equestInstance.isPolling(method = 'get') // returns true when polling is enabled

There is missing an "R" in the last request example.

requestInstance.isPending(method = '') // returns true when a request is on the fly
requestInstance.isUpdating(method = 'post') // returns true when a request is on the fly after interval request
requestInstance.isPolling(method = 'get') // returns true when polling is enabled

:)

When executing the below code, there is no support for Promise.finally should the poll be broken by return false. Is this something I'm just doing incorrectly?

LoadResults (callback) {
   const rq = new Request("...");
   var counter = 0;
   return rq.poll(2000).get(response => {
      callback(response);
      counter++;
      if(counter === 5) return false;
   });
}

Elsewhere:

InvokeResults () {
   return Handler.LoadResults(response => {
      ctx.commit("UPDATE_RESULTS", response.data);
   }).finally(() => {
      this.Loading = false;
   });
}

Ultimately, this.Loading never gets set to false