Make online compile error about app-trapper HOT 6 CLOSED

Hi Sebastian,

Oh, thanks for pointing out the issue. You are right, it should be:

snprintf(tmp, MAX_STR_LEN, COMMAND_LPG_1SOL_REPLAN, TOOLDIR, seed, inputplan);

I guess the issue occurred after I fixed the offline version (which share commands with the online one).

Apologies for my omission.

from app-trapper.

Does this work for you @lchrpa ? The offline works perfectly though

from app-trapper.

It seems it does not like:

#define COMMAND_LPG_1SOL "%s/lpg -f pfile.pddl -o domain.pddl -out soln.tmp -n 1 -seed %d -cputime 60 -nobestfirst -inst_with_contraddicting_objects -same_objects"

Interestingly, the line just after in the else does work well:

 snprintf(tmp, MAX_STR_LEN, COMMAND_LPG_1SOL_REPLAN, seed, inputplan);

where:

#define COMMAND_LPG_1SOL_REPLAN "%s/lpg -f pfile.pddl -o domain.pddl -n 1 -seed %d -cputime 60 -input_plan %s"

What I don't understand is how the first %s is filled in in both cases?!?! In fact, if I delete %s from the first one, it does compile well.

That %s is the path to the executable lpg, don't we need to pass that data in those lines?

from app-trapper.

Following it a bit more, shouldn't the %s be filled with __TOOLDIR__? I don't understand how the line:

 snprintf(tmp, MAX_STR_LEN, COMMAND_LPG_1SOL_REPLAN, seed, inputplan);

happens to work, because COMMAND_LPG_1SOL_REPLAN has three placeholders, but we are only filling two: seed and inputplan.

I am clearly missing something big here due to my lack of C knowledge!

from app-trapper.

I propose this change:

from app-trapper.

Thanks for confirming Lukas!

from app-trapper.