I love Intellij IDEA, except the part that it's not handle non-javadoc comments nicely. Some time we need that type of comment to explain why we wrote code like that. and not other way.
Beside that, this repo is not only about Android. And lots of people still prefer Eclipse or Netbeans for their java development. There are Eclipse Formmater plugins for Intellij and Netbeans. So, adding only one more xml file may help lots of people.

I plan to make a pull request for this. But I'm not sure if it worth doing that.

Hi,

First of all, thanks for the nice java code styles! I'm using it in my several java and android projects.

I see that you're developing a few projects in Kotlin. Do you have any code styles for Kotlin and can you share them? If not, then can you recommend any code styles ready to import to IntelliJ or Android Studio? How do you approach code formatting and code style in your Kotlin projects to keep code-base consistent?

Regards,
Piotr

This style should be unchecked

• Tried to import the styles into Intellij Idea CE 2020.1
• But import does not seem to take effect.
• Looks like Intellij configuration directory has been changed as per (https://www.jetbrains.com/help/idea/2020.1/tuning-the-ide.html?_ga=2.19808703.666856556.1587275963-1788437375.1573216295#default-dirs)

code style: SquareAndroid
When I reformat the xml, it change the tags order in xml. But the Square won't do this.

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="vertical">

  <com.xxx.widget.ItemView
      android:id="@+id/first"
      android:layout_width="match_parent"
      android:layout_height="@dimen/dp_60" />

  <View
      android:id="@+id/divider1"
      android:layout_width="match_parent"
      android:layout_height="@dimen/dp_0_5"
      android:layout_marginStart="@dimen/dp_25"
      android:background="#eeeeee" />

  <com.xxx.widget.ItemView
      android:id="@+id/second"
      android:layout_width="match_parent"
      android:layout_height="@dimen/dp_60"
      android:visibility="gone" />

  <View
      android:id="@+id/divider2"
      android:layout_width="match_parent"
      android:layout_height="@dimen/dp_0_5"
      android:layout_marginStart="@dimen/dp_25"
      android:background="#eeeeee" />

  <com.xxx.widget.ItemView
      android:id="@+id/third"
      android:layout_width="match_parent"
      android:layout_height="@dimen/dp_60"
      android:visibility="gone" />

</LinearLayout>

After reformat :

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="vertical">

  <View
      android:id="@+id/divider1"
      android:layout_width="match_parent"
      android:layout_height="@dimen/dp_0_5"
      android:layout_marginStart="@dimen/dp_25"
      android:background="#eeeeee" />

  <View
      android:id="@+id/divider2"
      android:layout_width="match_parent"
      android:layout_height="@dimen/dp_0_5"
      android:layout_marginStart="@dimen/dp_25"
      android:background="#eeeeee" />

  <com.xxx.widget.ItemView
      android:id="@+id/second"
      android:layout_width="match_parent"
      android:layout_height="@dimen/dp_60"
      android:visibility="gone" />

  <com.xxx.widget.ItemView
      android:id="@+id/first"
      android:layout_width="match_parent"
      android:layout_height="@dimen/dp_60" />

  <com.xxx.widget.ItemView
      android:id="@+id/third"
      android:layout_width="match_parent"
      android:layout_height="@dimen/dp_60"
      android:visibility="gone" />

</LinearLayout>

  private fun createTemporaryCoverageFiles(serialId1: String, serialId2: String) {

The current code style forces that to

  private fun createTemporaryCoverageFiles(
    serialId1: String,
    serialId2: String
  ) {

Which seems wrong to me. It also does some aggressive line-wraps around long method calls that I think is wrong:

            assertThat(cliArgs).isEqualTo(
                "this assertion shouldn't be executed, exception is expected")

turns into

            assertThat(cliArgs).isEqualTo(
                "this assertion shouldn't be executed, exception is expected"
            )

Are these intentional? Want me to submit a PR to fix?

If the ELSE statements are on the same line, code looks a bit messier and the else statement cannot be collapsed from the side either.

ELSE is unable to collapse. And the lack of blank space makes the else harder to see and not inline.

This is with it enabled. It collapse and it's cleaner.

For ConstraintLayout

Hello. I was using this code style in Android Studio 1.1 without any trouble. I updated to the canary 1.2 version and i am trying to set the code style again, but it does not appear when i try to "manage" code styles. What's the matter with it? Might the ~/AndroidStudio/config/codestyles folder have changed its path or name ? I runned the installation script again, but still happening.

Thanks in advance.

:square:coding:

I have been struggling how to add this coding style.
After running file ./install.sh it says restart android and select preference but I haven't know where is a preference to select.

Log.
jsroyal@HP:~/java-code-styles-master$ ./install.sh
Installing Square IntelliJ configs...
'/home/jsroyal/java-code-styles-master/configs/codestyles/SquareAndroid.xml' -> '/home/jsroyal/.AndroidStudio2.2/config/codestyles/SquareAndroid.xml'
'/home/jsroyal/java-code-styles-master/configs/codestyles/Square.xml' -> '/home/jsroyal/.AndroidStudio2.2/config/codestyles/Square.xml'
'/home/jsroyal/java-code-styles-master/configs/inspection/Square.xml' -> '/home/jsroyal/.AndroidStudio2.2/config/inspection/Square.xml'
'/home/jsroyal/java-code-styles-master/configs/options/editor.codeinsight.xml' -> '/home/jsroyal/.AndroidStudio2.2/config/options/editor.codeinsight.xml'
'/home/jsroyal/java-code-styles-master/configs/codestyles/SquareAndroid.xml' -> '/home/jsroyal/.AndroidStudio2.3/config/codestyles/SquareAndroid.xml'
'/home/jsroyal/java-code-styles-master/configs/codestyles/Square.xml' -> '/home/jsroyal/.AndroidStudio2.3/config/codestyles/Square.xml'
'/home/jsroyal/java-code-styles-master/configs/inspection/Square.xml' -> '/home/jsroyal/.AndroidStudio2.3/config/inspection/Square.xml'
'/home/jsroyal/java-code-styles-master/configs/options/editor.codeinsight.xml' -> '/home/jsroyal/.AndroidStudio2.3/config/options/editor.codeinsight.xml'
Done.

Restart IntelliJ and/or AndroidStudio, go to preferences, and apply 'Square' or 'SquareAndroid'.
jsroyal@HP:~/java-code-styles-master$

i have already set code style to "SquareAndroid", but after reopen android-studio, it is reset to Default code style. this issue occurred recently, i guess maybe is for i upgrade my android-studio to 3.2.1. Even i have tried execute to install.sh, this issue remains there. Anyone else get this issue?
this is my android-studio's version:

https://www.jetbrains.com/help/idea/sharing-your-ide-settings.html#share-more-settings-through-read-only-repo

https://confluence.jetbrains.com/display/IDEADEV/New+project+code+style+settings+format+in+2017.3

Is there a reason the SquareAndroid style is not using the official style IDE support introduced with Kotlin 1.3?
I forked the config and made minimal changes to support this. Not sure whats the reason behind using custom rules (I guess they originate from a time before the official IDE support)?

Currently applying the SquareAndroid config project wide breaks appropriate ktx view binding imports (NAME_COUNT_TO_USE_STAR_IMPORT=999) and other essential Kotlin specific code styles.

Wanted to open this issue first to hear out your thoughts instead of opening a PR right away. :)

While @JakeWharton brought up converting this entire thing to a settings repository (#74), this is a request to support personal settings-repositories.

The "SquareAndroid" code style doesn't have any XML arrangement predefined. (Editor > Code Style > XML > (Scheme:SquareAndroid) Arrangement )

I'm setting it by using "Set From > Predefined style > Android" to enforce XML tags arrangement.

Is this an intended behavior? If not can I make a PR?

This is some historical baggage or accident. It shouldn't be too hard to converge on a single style.

Getting this error while installing on Ubuntu 17.10

install.sh: 6: install.sh: Bad substitution
install.sh: 15: install.sh: [[: not found
install.sh: 15: install.sh: [[: not found
install.sh: 15: install.sh: [[: not found
install.sh: 15: install.sh: [[: not found
install.sh: 15: install.sh: [[: not found
install.sh: 15: install.sh: [[: not found
install.sh: 15: install.sh: [[: not found

install.sh has this code on line 15
if [[ -d $i ]]; then

I like your code style. However, when reformatting my code using your style I am encountering various checkstyle violations for either Sun's or Google's default rules. It mostly complains about whitespaces before/after curly braces, line length and such stuff.

So my question is, if there exists a particular checkstyle-rules.xml for this style? Maybe it's a good idea to have both in place, code style along with dedicated check.

I've looked into the ones you are using in your projects, for instance Dagger, but actually it just omits some rules.

Thanks in advance.

Most things should already be in the style guide.
But we should double check and discuss Kotlins official style guide.

Hi,

What do you think about supporting .editorconfig file format? It looks like pretty interesting project and it's independent from the IDE. I suppose, such support would require writing 2 new .editorconfig files basing on config/codestyles/Square.xml and config/codestyles/SquareAndroid.xml.

Reference link: https://editorconfig.org/

By the way: thanks for providing great code styles. I'm using it in all of my java, kotlin and android open-source projects :).

Regards,
Piotr

Tried to load SquareAndroid.xml rules

org.infernus.idea.checkstyle.exception.CheckStylePluginException: The Checkstyle rules file could not be loaded.
unable to parse configuration stream - Document is invalid: no grammar found.:1:13
The file has been blacklisted for 60s.
at org.infernus.idea.checkstyle.checker.CheckerFactory.blacklistAndShowMessage(CheckerFactory.java:214)
at org.infernus.idea.checkstyle.checker.CheckerFactory.createChecker(CheckerFactory.java:170)
at org.infernus.idea.checkstyle.checker.CheckerFactory.getOrCreateCachedChecker(CheckerFactory.java:82)
at org.infernus.idea.checkstyle.checker.CheckerFactory.checker(CheckerFactory.java:61)
at org.infernus.idea.checkstyle.checker.CheckerFactory.verify(CheckerFactory.java:42)
at org.infernus.idea.checkstyle.ui.LocationDialogue.attemptLoadOfFile(LocationDialogue.java:198)
at org.infernus.idea.checkstyle.ui.LocationDialogue.access$800(LocationDialogue.java:24)
at org.infernus.idea.checkstyle.ui.LocationDialogue$NextAction.actionPerformed(LocationDialogue.java:241)
at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
at java.awt.Component.processMouseEvent(Component.java:6535)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
at java.awt.Component.processEvent(Component.java:6300)
at java.awt.Container.processEvent(Container.java:2236)
at java.awt.Component.dispatchEventImpl(Component.java:4891)
at java.awt.Container.dispatchEventImpl(Container.java:2294)
at java.awt.Component.dispatchEvent(Component.java:4713)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
at java.awt.Container.dispatchEventImpl(Container.java:2280)
at java.awt.Window.dispatchEventImpl(Window.java:2750)
at java.awt.Component.dispatchEvent(Component.java:4713)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
at java.awt.EventQueue.access$500(EventQueue.java:97)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.awt.EventQueue$3.run(EventQueue.java:703)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.awt.EventQueue$4.run(EventQueue.java:731)
at java.awt.EventQueue$4.run(EventQueue.java:729)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:866)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:650)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:381)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:109)
at java.awt.WaitDispatchSupport$2.run(WaitDispatchSupport.java:184)
at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:229)
at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:227)
at java.security.AccessController.doPrivileged(Native Method)
at java.awt.WaitDispatchSupport.enter(WaitDispatchSupport.java:227)
at java.awt.Dialog.show(Dialog.java:1084)
at java.awt.Component.show(Component.java:1673)
at java.awt.Component.setVisible(Component.java:1625)
at java.awt.Window.setVisible(Window.java:1014)
at java.awt.Dialog.setVisible(Dialog.java:1005)
at org.infernus.idea.checkstyle.ui.LocationDialogue.setVisible(LocationDialogue.java:151)
at org.infernus.idea.checkstyle.ui.CheckStyleConfigPanel$AddLocationAction.actionPerformed(CheckStyleConfigPanel.java:326)
at org.infernus.idea.checkstyle.ui.CheckStyleConfigPanel$ToolbarAction.run(CheckStyleConfigPanel.java:401)
at org.infernus.idea.checkstyle.ui.CheckStyleConfigPanel$ToolbarAction.run(CheckStyleConfigPanel.java:396)
at com.intellij.ui.ToolbarDecorator$3.doAdd(ToolbarDecorator.java:434)
at com.intellij.ui.CommonActionsPanel$Buttons.performAction(CommonActionsPanel.java:71)
at com.intellij.ui.CommonActionsPanel$MyActionButton.actionPerformed(CommonActionsPanel.java:261)
at com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAware(ActionUtil.java:182)
at com.intellij.openapi.actionSystem.impl.ActionButton.actionPerformed(ActionButton.java:162)
at com.intellij.openapi.actionSystem.impl.ActionButton.performAction(ActionButton.java:126)
at com.intellij.openapi.actionSystem.impl.ActionButton.processMouseEvent(ActionButton.java:300)
at java.awt.Component.processEvent(Component.java:6300)
at java.awt.Container.processEvent(Container.java:2236)
at java.awt.Component.dispatchEventImpl(Component.java:4891)
at java.awt.Container.dispatchEventImpl(Container.java:2294)
at java.awt.Component.dispatchEvent(Component.java:4713)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
at java.awt.Container.dispatchEventImpl(Container.java:2280)
at java.awt.Window.dispatchEventImpl(Window.java:2750)
at java.awt.Component.dispatchEvent(Component.java:4713)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
at java.awt.EventQueue.access$500(EventQueue.java:97)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.awt.EventQueue$3.run(EventQueue.java:703)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.awt.EventQueue$4.run(EventQueue.java:731)
at java.awt.EventQueue$4.run(EventQueue.java:729)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:866)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:650)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:381)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:109)
at java.awt.WaitDispatchSupport$2.run(WaitDispatchSupport.java:184)
at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:229)
at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:227)
at java.security.AccessController.doPrivileged(Native Method)
at java.awt.WaitDispatchSupport.enter(WaitDispatchSupport.java:227)
at java.awt.Dialog.show(Dialog.java:1084)
at com.intellij.openapi.ui.impl.DialogWrapperPeerImpl$MyDialog.show(DialogWrapperPeerImpl.java:792)
at com.intellij.openapi.ui.impl.DialogWrapperPeerImpl.show(DialogWrapperPeerImpl.java:465)
at com.intellij.openapi.ui.DialogWrapper.invokeShow(DialogWrapper.java:1638)
at com.intellij.openapi.ui.DialogWrapper.show(DialogWrapper.java:1587)
at com.intellij.ide.actions.ShowSettingsUtilImpl.showSettingsDialog(ShowSettingsUtilImpl.java:118)
at com.intellij.ide.actions.ShowSettingsAction.actionPerformed(ShowSettingsAction.java:65)
at com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAware(ActionUtil.java:182)
at com.intellij.openapi.actionSystem.impl.ActionButton.actionPerformed(ActionButton.java:162)
at com.intellij.openapi.actionSystem.impl.ActionButton.performAction(ActionButton.java:126)
at com.intellij.openapi.actionSystem.impl.ActionButton.processMouseEvent(ActionButton.java:300)
at java.awt.Component.processEvent(Component.java:6300)
at java.awt.Container.processEvent(Container.java:2236)
at java.awt.Component.dispatchEventImpl(Component.java:4891)
at java.awt.Container.dispatchEventImpl(Container.java:2294)
at java.awt.Component.dispatchEvent(Component.java:4713)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
at java.awt.Container.dispatchEventImpl(Container.java:2280)
at java.awt.Window.dispatchEventImpl(Window.java:2750)
at java.awt.Component.dispatchEvent(Component.java:4713)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
at java.awt.EventQueue.access$500(EventQueue.java:97)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.awt.EventQueue$3.run(EventQueue.java:703)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.awt.EventQueue$4.run(EventQueue.java:731)
at java.awt.EventQueue$4.run(EventQueue.java:729)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:866)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:650)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:381)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

没的mac的脚本吗？