sprintup / fizzbuzz Goto Github PK

Step 1 commit was done without Maven, I was just using command line and IntelliJ IDE. Therefor, the two paths to fizzbuzz from the root directory are not attached to a project in the sense they don't have a POM file. These can be deleted, but I thought maybe you would want to see them. More details are here.

I understand how the pom file is important to configuring microservices, so before the second step, I followed: https://maven.apache.org/guides/getting-started/maven-in-five-minutes.html

Here are the changes before step 2.

Step 2 | commit, I just copied the code from step 1 into the new Maven project (my-app)

Step 3 | commit

• I'm not sure if the 'output' is the return value or the side-effect (log). Both are possible, but implementation is different. I'm going assume it's the log, since machines wouldn't be able to read reports very easily. Further, to have it in the right order (oneline for array, then the report) I'm going to ask the project manager if it makes a difference to the end user.
• The hashtable works, but there is something wrong with the test, where it is only showing the integer. More familiarity with java would help, but it could be it could be something with the testing framework too, since the correct string is printed just before the return. It could be that I'm passing multiple integers with a space as a delimiter. This is something I would document and bring up in code review, it's documented in issue #3.