add methods to Request to add parameters about apollo HOT 6 CLOSED

A reference could be HttpUrl from OkHttp. Their choice was to separate the URL into a different type from the Request. Seems like introducing a similar type into Apollo might be good?

from apollo.

@pettermahlen I think that would be useful. I've wished a few times for something similar to a URIBuilder from Jersey or Http Client that was a bit more standard (especially when not using one of those libraries).

from apollo.

I'm thinking if the use case is HTTP urls, then perhaps using HttpUrl might be a good solution? Reading the HttpUrl (which is based on experiences from URL, URI and URIBuilder) javadocs, it's striking that creating such a class is a pretty significant effort. Duplicating that in Apollo seems a little wasteful if not strictly necessary.

from apollo.

I agree on avoiding duplication (or second efforts to create standards-correct URI builders). HttpUrl sounds good to me since it looks very standalone from the rest of okhttp 👍

from apollo.

So can we close this and recommend the use of this pattern:

  HttpUrl httpUrl = ... ;
  Request.forUri(httpUrl.toString());

It's maybe a bit dangerous given that the behaviour of toString() isn't defined in the javadocs. Also, that leaves us without a solution for Hermes URLs, but that's maybe less of a problem as query parameters aren't very commonly used with Hermes.

from apollo.

Sounds good!

from apollo.