Comments (6)
A reference could be HttpUrl from OkHttp. Their choice was to separate the URL into a different type from the Request
. Seems like introducing a similar type into Apollo might be good?
from apollo.
@pettermahlen I think that would be useful. I've wished a few times for something similar to a URIBuilder from Jersey or Http Client that was a bit more standard (especially when not using one of those libraries).
from apollo.
I'm thinking if the use case is HTTP urls, then perhaps using HttpUrl
might be a good solution? Reading the HttpUrl (which is based on experiences from URL, URI and URIBuilder) javadocs, it's striking that creating such a class is a pretty significant effort. Duplicating that in Apollo seems a little wasteful if not strictly necessary.
from apollo.
I agree on avoiding duplication (or second efforts to create standards-correct URI builders). HttpUrl sounds good to me since it looks very standalone from the rest of okhttp 👍
from apollo.
So can we close this and recommend the use of this pattern:
HttpUrl httpUrl = ... ;
Request.forUri(httpUrl.toString());
It's maybe a bit dangerous given that the behaviour of toString() isn't defined in the javadocs. Also, that leaves us without a solution for Hermes URLs, but that's maybe less of a problem as query parameters aren't very commonly used with Hermes.
from apollo.
Sounds good!
from apollo.
Related Issues (20)
- Add Middleware to a set o routes HOT 2
- Problems building examples HOT 2
- Is there support for CORS? If not, are there plans to add it? If not, can I submit a PR? HOT 2
- How to get remote client IP for a request? HOT 4
- Change master branch back to 1.x branch? HOT 5
- Unable to build project HOT 4
- Requests with "Transfer-Encoding: chunked" wrongly conclude that no payload is being sent HOT 1
- Security: is possible to add role to Route URI? HOT 6
- Java 9 Illegal Access Warnings HOT 1
- Server Side Event for server-side push HOT 2
- File Upload HOT 2
- Route execution elapsed time HOT 2
- Swagger or ReST Documentation HOT 2
- how to run this with gradle ? HOT 1
- Download resource HOT 1
- Connect to DB HOT 1
- Example is missing in Readme.md HOT 2
- Upgrade to Guice 5 HOT 2
- Modules with decorators are restricted by order they are declared HOT 1
- Bom should not have a parent
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apollo.