Consider using currency codes about cryptocurrency-icons HOT 11 CLOSED

f8a0efa

from cryptocurrency-icons.

Some names are still wrong. miota should be iot also there are whitespaces in the names cryptocurrency-icons/svg/icon/ada .svg (as example)

from cryptocurrency-icons.

That's a great idea. Let me make sure those are consistent in the next update 👍

from cryptocurrency-icons.

Cool. I can also do it for myself and submit a PR but I wanted to see your reaction to the idea before I spend time on it.

from cryptocurrency-icons.

That's kind - I appreciate the offer. I batch renamed those in the source file and am working on an update including new icons and updates as we speak :)

from cryptocurrency-icons.

@cjdowner can we have an update on this?

from cryptocurrency-icons.

I've made a fork of the repo. Working on renaming stuff correctly. Two proposed changes I'd maybe roll into one, and I'm posting here to get a second or third opinion on are:

• Use upper case codes. In most contexts I'm storing codes as strings and avoid having to transform them if the string is just "USD" or "BTC" or "ETH" or whatever. The file would be "ETH.png"
• Keep variants stored by currency. I realize this is just personal opinion but having different sizes of the same icon (or different formats) reminds me of keeping icon assets together in a folder like myIcon_32x32.png and [email protected]. Therefore I'd propose a structure with paths like /[CODE]/[STYLE]_[SIZE].[EXT]. So for example: /BTC/[email protected] or /ETH/icon.svg

These two suggestions aren't mutually inclusive so I could do one and not the other if it seems silly but I don't want to sit down and churn through this until I know exactly what I'm going for.

from cryptocurrency-icons.

@TAiS46 the currency codes are somewhat subjective. I sourced them from Coinmarketcap. I know Kraken for example do their own thing.

@ianpaschal thanks for the fork - you're very welcome to. I opted for lowercase names as that tends to be more of a standard in my experience, as with how I've delivered them, but I think personal preference comes into it too.

I will update fixing the whitespaces

from cryptocurrency-icons.

Ugh. Kraken. As if their platform wasn't broken enough already, I do a "Heh, whaaat?" every time I see "XBT" instead of "BTC".

I'm pretty busy this weekend so if you do it now you'll probably beat me to it with an update, although in this case I'll go for my different organizational structure so that it's out there if anyone prefers it.

Thanks for putting this resource together. I think it's the most complete crypto icon set out there.

from cryptocurrency-icons.

@ianpaschal Haha. Sure thing, I'll cc you on my commit.

Let me know when you get the opportunity to fork it, and I'll link to it on the readme as I'm sure people would like the option 👍

You're welcome – I don't always have the time, but do have more coins in the pipeline

from cryptocurrency-icons.

Not to be pedantic, but I don't think naming the files by their currency code is a good idea. Not only do some cryptocurrency codes clash (BTG for Bitcoin Gold and Bitgem), but also some cryptocurrency codes clash with fiat currencies (ALL for the fiat Albanian lek and the cryptocurrency Allion). Not to mention different exchanges use different currency codes.

I think it makes more unambiguous sense to name the icons by their actual currency name.

from cryptocurrency-icons.